Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): update Mergify config #5617

Merged
merged 2 commits into from
Jan 19, 2022
Merged

chore(build): update Mergify config #5617

merged 2 commits into from
Jan 19, 2022

Conversation

mattgogerly
Copy link
Member

@mattgogerly mattgogerly commented Jan 18, 2022 •
edited
Loading

No description provided.

@dbyron-sf
Copy link
Contributor

Similar to spinnaker/deck#9785 + spinnaker/deck#9786, right? Any differences worth calling out?

PS Thanks for doing this.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@mattgogerly
Copy link
Member Author

mattgogerly commented Jan 18, 2022 •
edited
Loading

Similar to spinnaker/deck#9785 + spinnaker/deck#9786, right? Any differences worth calling out?

PS Thanks for doing this.

Yup, looks like we're using strict across all repos and it was removed on the 6th.

Only difference is Deck's CI is slightly more complicated so the queue condition is different, but otherwise identical.

edit: I can't fix that commit name on mobile so feel free to do with it as you please

@dbyron-sf dbyron-sf merged commit dfe646e into master Jan 19, 2022
@dbyron-sf dbyron-sf deleted the mattgogerly-patch-1 branch January 19, 2022 03:19
@link108
Copy link
Member

link108 commented Jan 19, 2022

@Mergifyio backport release-1.27.x release-1.26.x

mergify bot pushed a commit that referenced this pull request Jan 19, 2022
@mattgogerly
chore(build): update Mergify config (#5617)
abd920e 
* chore(build): update Mergify config

* Update .mergify.yml

(cherry picked from commit dfe646e)
@mergify mergify bot mentioned this pull request Jan 19, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jan 19, 2022
@mattgogerly
chore(build): update Mergify config (#5617)
d806e4e 
* chore(build): update Mergify config

* Update .mergify.yml

(cherry picked from commit dfe646e)
@mergify mergify bot mentioned this pull request Jan 19, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

backport release-1.27.x release-1.26.x

✅ Backports have been created

@link108 link108 mentioned this pull request Jan 19, 2022
Merged
mergify bot added a commit that referenced this pull request Jan 19, 2022
@mergify @mattgogerly
chore(build): update Mergify config (#5617) (#5618)
8c1e9ec 
* chore(build): update Mergify config

* Update .mergify.yml

(cherry picked from commit dfe646e)

Co-authored-by: Matt <6519811+mattgogerly@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jan 19, 2022
@mergify @mattgogerly
chore(build): update Mergify config (#5617) (#5619)
c4be967 
* chore(build): update Mergify config

* Update .mergify.yml

(cherry picked from commit dfe646e)

Co-authored-by: Matt <6519811+mattgogerly@users.noreply.github.com>
This was referenced Jan 19, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@link108
Copy link
Member

link108 commented Jan 19, 2022

@Mergifyio backport release-1.25.x

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

backport release-1.25.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 19, 2022
@mattgogerly
chore(build): update Mergify config (#5617)
b47eda5 
* chore(build): update Mergify config

* Update .mergify.yml

(cherry picked from commit dfe646e)
@mergify mergify bot mentioned this pull request Jan 19, 2022
Open
@link108 link108 mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
target-release/1.28
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattgogerly @dbyron-sf @spinnakerbot @link108