Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): update Mergify config #9785

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

mattgogerly
Copy link
Member

The strict option is deprecated (brownout today). I think this config should be equivalent.

@christopherthielen
Copy link
Contributor

oh nice, thanks! can you link to the mergify docs that explain these changes?

@mattgogerly
Copy link
Member Author

mattgogerly commented Dec 6, 2021

oh nice, thanks! can you link to the mergify docs that explain these changes?

https://blog.mergify.com/strict-mode-deprecation/

I guess this CI won't succeed until the brownout finishes.

@dbyron-sf
Copy link
Contributor

Yes, thanks much @mattgogerly! This is a big help.

@mattgogerly
Copy link
Member Author

mattgogerly commented Dec 7, 2021

I'm unsure if the conditions in the queue config need to be duplicated in the main config like in the example. I'm hoping not..

I think this updated config will queue PRs once they're approved and have the appropriate label, then PRs in the queue will be checked sequentially for CI success and merged?

I wonder if having CI success as a condition for each block also would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants