feat(k8s): Add Deployment Kind support for Blue/Green deployments #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiupopa07
requested changes
Dec 7, 2022
ovidiupopa07
requested changes
Dec 13, 2022
...s/src/integration/java/com/netflix/spinnaker/clouddriver/kubernetes/it/DeployManifestIT.java
Outdated
Show resolved
Hide resolved
|
ovidiupopa07
approved these changes
Dec 14, 2022
dogonthehorizon
approved these changes
Dec 14, 2022
…nnaker#5834) The property spring.config.additional-location is redundant in clouddriver-web.gradle file. This property is set by class com.netflix.spinnaker.kork.boot.DefaultPropertiesBuilder in com.netflix.spinnaker.clouddriver.Main. So removing it from gradle file.
…rca (spinnaker#5833) Co-authored-by: Apoorv Mahajan <amahaja3@ncsu.edu> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@923768a73b79>
Co-authored-by: root <root@460f62b24dfe>
Co-authored-by: root <root@bd924b84c45e>
Co-authored-by: root <root@c0db2dce1dda>
…rward (spinnaker#5840) with a specific goal to get org.testng:testng:7.4.0 out of shipping code, since it's vulnerable to CVE-2022-4065. Note: groovy-all and testng remain in clouddriver-yandex, but they're gone (besides test configurations) elsewhere. test(integration): test red/black deployment test(integration): test blue/green deployment
dbyron-sf
reviewed
Dec 21, 2022
| @@ -82,7 +86,7 @@ public KubernetesKind kind() { | |||
|
|
|||
| @Override | |||
| public boolean versioned() { | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
This change breaks a bunch of integration tests (which unfortunately weren't required to pass before merging this PR), but also is a pretty massive behavior change. Before people who deploy a deployment named foo, would get foo. Now they get foo-vNNN. It also makes https://spinnaker.io/docs/reference/providers/kubernetes-v2/#workloads incorrect for Deployments. I'm not sure how critical this change is to this PR....
There was a problem hiding this comment.
PR to revert this one: #5843
dbyron-sf
added a commit
to dbyron-sf/clouddriver
that referenced
this pull request
Dec 21, 2022
…ents (spinnaker#5830)" This reverts commit 932dd66. See https://github.com/spinnaker/clouddriver/pull/5830/files#r1054854915 for details, but versioning deployments causes test failures and is a big behavior change. Reverting until we can figure out a better way.
mergify bot
pushed a commit
that referenced
this pull request
Dec 21, 2022
…ents (#5830)" (#5843) This reverts commit 932dd66. See https://github.com/spinnaker/clouddriver/pull/5830/files#r1054854915 for details, but versioning deployments causes test failures and is a big behavior change. Reverting until we can figure out a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Clouddriver to support Deployment kind for Red/Black (deprecated) deployments, which will become Blue/Green.