chore(dependencies): remove dependency on groovy-all where straightforward #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rward with a specific goal to get org.testng:testng:7.4.0 out of shipping code, since it's vulnerable to CVE-2022-4065. Note: groovy-all and testng remain in clouddriver-yandex, but they're gone (besides test configurations) elsewhere.
dbyron-sf
requested review from
jeyrschabu,
aravindmd,
ajordens,
cfieber,
zachsmith1,
plumpy,
skandragon,
clanesf and
german-muzquiz
as code owners
| @@ -3,7 +3,7 @@ dependencies { | |||
|
|
|||
| implementation "org.slf4j:slf4j-api" | |||
| implementation "com.fasterxml.jackson.core:jackson-annotations" | |||
| implementation "org.codehaus.groovy:groovy-all" | |||
| implementation "org.codehaus.groovy:groovy" | |||
There was a problem hiding this comment.
IF we change this to API, it should expose it downstream (aka cats-core being a java librayr, no need for implementation downstream)
jasonmcintosh
approved these changes
Dec 9, 2022
ciurescuraul
pushed a commit
to armory-io/clouddriver
that referenced
this pull request
Dec 15, 2022
…rward (spinnaker#5840) with a specific goal to get org.testng:testng:7.4.0 out of shipping code, since it's vulnerable to CVE-2022-4065. Note: groovy-all and testng remain in clouddriver-yandex, but they're gone (besides test configurations) elsewhere. test(integration): test red/black deployment test(integration): test blue/green deployment
mergify bot
added a commit
that referenced
this pull request
Dec 15, 2022
) * feat(k8s): Add Deployment Kind support for Blue/Green deployments * test(integration): test red/black deployment * test(integration): test blue/green deployment * refactor(web): Clean up redundant spring property in gradle file (#5834) The property spring.config.additional-location is redundant in clouddriver-web.gradle file. This property is set by class com.netflix.spinnaker.kork.boot.DefaultPropertiesBuilder in com.netflix.spinnaker.clouddriver.Main. So removing it from gradle file. * feat(kubernetes): add endpoints to allow k8s tasks to be retried by orca (#5833) Co-authored-by: Apoorv Mahajan <amahaja3@ncsu.edu> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * chore(dependencies): Autobump korkVersion (#5836) Co-authored-by: root <root@923768a73b79> * chore(dependencies): Autobump korkVersion (#5837) Co-authored-by: root <root@460f62b24dfe> * chore(dependencies): Autobump korkVersion (#5838) Co-authored-by: root <root@bd924b84c45e> * chore(dependencies): Autobump korkVersion (#5839) Co-authored-by: root <root@c0db2dce1dda> * chore(dependencies): remove dependency on groovy-all where straightforward (#5840) with a specific goal to get org.testng:testng:7.4.0 out of shipping code, since it's vulnerable to CVE-2022-4065. Note: groovy-all and testng remain in clouddriver-yandex, but they're gone (besides test configurations) elsewhere. test(integration): test red/black deployment test(integration): test blue/green deployment Co-authored-by: Sandesh <30489233+j-sandy@users.noreply.github.com> Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com> Co-authored-by: Apoorv Mahajan <amahaja3@ncsu.edu> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: spinnakerbot <spinbot@spinnaker.io> Co-authored-by: root <root@923768a73b79> Co-authored-by: root <root@460f62b24dfe> Co-authored-by: root <root@bd924b84c45e> Co-authored-by: root <root@c0db2dce1dda>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with a specific goal to get org.testng:testng:7.4.0 out of shipping code, since it's vulnerable to CVE-2022-4065.
Note: groovy-all and testng remain in clouddriver-yandex, but they're gone (besides test configurations) elsewhere.