fix(gcp): Relaxed health check for GCP accounts #6200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiupopa07
approved these changes
May 1, 2024
|
Ideally this gets changed a bit in the future. With the Bean, it would disable the thread & scheduled job which would output a log message every 30 seconds. Since it was also a component that Bean disable didn't help this. Doing this method, we still get the log message, the scheduled run that outputs the log message every 30 seconds, plus the whole if check thing. It's MINOR but... we shouldn't really load these health checks this way. Be good to fix all of them to disable them vs. the current implementation. |
|
@Mergifyio backport release-1.28.x |
✅ Backports have been created
|
|
@Mergifyio backport release-1.34.x release-1.33.x release-1.32.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2024
(cherry picked from commit 28599eb) # Conflicts: # clouddriver-google/src/main/groovy/com/netflix/spinnaker/clouddriver/google/health/GoogleHealthIndicator.groovy
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2024
(cherry picked from commit 28599eb)
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2024
(cherry picked from commit 28599eb)
This was referenced May 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2024
(cherry picked from commit 28599eb)
mergify bot
added a commit
that referenced
this pull request
May 7, 2024
* fix(gcp): Relaxed health check for GCP accounts (#6200) (cherry picked from commit 28599eb) # Conflicts: # clouddriver-google/src/main/groovy/com/netflix/spinnaker/clouddriver/google/health/GoogleHealthIndicator.groovy * fix: Fixes PR to match 1.28 versions of credential repository APIs --------- Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io> Co-authored-by: Jason McIntosh <jason.mcintosh@harness.io>
aman-agrawal
pushed a commit
to aman-agrawal/clouddriver
that referenced
this pull request
Jul 5, 2024
…nnaker#6203) (cherry picked from commit 28599eb) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of cloud providers (AWS, K8s) and dockerRegistry have already implementations for relaxed health checks via a configuration property in the respective provider block.
On GCP provider though it was attempted to be addressed by #6093 which however was not the correct implementation since the Health check is registered in initialisation and it is a scheduled task.
This PR fixes the issue spinnaker/spinnaker#3923 for the GCP provider