fix(gcp): Relaxed health check for GCP accounts (backport #6200) #6203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 28599eb)
jasonmcintosh
approved these changes
May 7, 2024
aman-agrawal
pushed a commit
to aman-agrawal/clouddriver
that referenced
this pull request
Jul 5, 2024
…nnaker#6203) (cherry picked from commit 28599eb) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of cloud providers (AWS, K8s) and dockerRegistry have already implementations for relaxed health checks via a configuration property in the respective provider block.
On GCP provider though it was attempted to be addressed by #6093 which however was not the correct implementation since the Health check is registered in initialisation and it is a scheduled task.
This PR fixes the issue spinnaker/spinnaker#3923 for the GCP provider
This is an automatic backport of pull request #6200 done by Mergify.