fix(liquibase): fix checkSum errors occurring with spinnaker upgrade #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
kirangodishala
changed the title
dbyron-sf
reviewed
May 22, 2024
clouddriver-sql/src/main/resources/db/changelog/20181120-cats.yml
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
fcd13ec
to
6b5d089
Compare
dbyron-sf
reviewed
May 31, 2024
clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/BaseContainerTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
May 31, 2024
clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/BaseContainerTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
May 31, 2024
clouddriver-sql/src/main/resources/db/changelog/20190913-task-sagaids.yml
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
May 31, 2024
clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/BaseContainerTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
May 31, 2024
clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/BaseContainerTest.java
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
90b2543
to
80cd2ec
Compare
dbyron-sf
reviewed
Jun 3, 2024
clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/BaseContainerTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jun 3, 2024
clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/MySqlContainerTest.java
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
80cd2ec
to
edba620
Compare
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
edba620
to
8cf07db
Compare
dbyron-sf
reviewed
Jun 4, 2024
clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/MySqlContainerTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jun 4, 2024
...river-integration/src/test/java/com/netflix/spinnaker/clouddriver/PostgresContainerTest.java
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
8cf07db
to
06c5dac
Compare
|
Moved integration testes to a separate PR - #6221 |
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
06c5dac
to
e3308b1
Compare
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
e3308b1
to
db5feb9
Compare
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
543adf5
to
88fd71b
Compare
dbyron-sf
added a commit
to dbyron-sf/kork
that referenced
this pull request
Jun 6, 2024
)" This reverts commit 4ff407e. Turns out that we don't need liquibase 4.27.0 to fix migration issues with postgres. spinnaker/clouddriver#6217 fixes the migration with 4.24.0.
mergify bot
pushed a commit
to spinnaker/kork
that referenced
this pull request
Jun 7, 2024
) This reverts commit 4ff407e. Turns out that we don't need liquibase 4.27.0 to fix migration issues with postgres. spinnaker/clouddriver#6217 fixes the migration with 4.24.0.
|
@Mergifyio update |
✅ Branch has been successfully updated |
dbyron-sf
approved these changes
Jun 7, 2024
|
@Mergifyio backport release-1.33.x release-1.34.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
…6217) * fix(tests): added postgres migration test * fix(tests): hardcoded the docker image to create initial conditions * fix(liquibase): add validCheckSum values to fix failing changesets --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad1a8ef) # Conflicts: # clouddriver-integration/src/test/java/com/netflix/spinnaker/clouddriver/StandaloneContainerTest.java
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
…6217) * fix(tests): added postgres migration test * fix(tests): hardcoded the docker image to create initial conditions * fix(liquibase): add validCheckSum values to fix failing changesets --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad1a8ef)
|
@Mergifyio backport release-1.33.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…6217) (#6232) * fix(tests): added postgres migration test * fix(tests): hardcoded the docker image to create initial conditions * fix(liquibase): add validCheckSum values to fix failing changesets --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad1a8ef) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
dbyron-sf
pushed a commit
that referenced
this pull request
Jun 11, 2024
…6217) * fix(tests): added postgres migration test * fix(tests): hardcoded the docker image to create initial conditions * fix(liquibase): add validCheckSum values to fix failing changesets --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad1a8ef)
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…6217) (#6231) * fix(tests): added postgres migration test * fix(tests): hardcoded the docker image to create initial conditions * fix(liquibase): add validCheckSum values to fix failing changesets --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad1a8ef) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
aman-agrawal
pushed a commit
to aman-agrawal/clouddriver
that referenced
this pull request
Jul 5, 2024
…pinnaker#6217) (spinnaker#6231) * fix(tests): added postgres migration test * fix(tests): hardcoded the docker image to create initial conditions * fix(liquibase): add validCheckSum values to fix failing changesets --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad1a8ef) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
aman-agrawal
pushed a commit
to OpsMx/clouddriver-oes
that referenced
this pull request
Jul 8, 2024
…pinnaker#6217) (spinnaker#6231) * fix(tests): added postgres migration test * fix(tests): hardcoded the docker image to create initial conditions * fix(liquibase): add validCheckSum values to fix failing changesets --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad1a8ef) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes checkSum errors caused after liquibase upgrade(to 4.24.0) as the checksum calculation underwent some changes causing this issue.
This PR fixes the checksum errors by adding validChecksum tags to the failing changesets.
Added an integration test to verify the migration scenario with postgres. This will be useful to identify and avoid issues when liquibase is upgraded or if any changesets are modified.
Similar orca PR for reference: spinnaker/orca#4727