chore(build): enable cross compilation plugin for Java 17 #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
approved these changes
Jun 11, 2024
since it's deprecated (see junit-team/junit5#1317). Once it's gone, the regular gradle test task properly reports failures.
…yFieldRecursively with usingRecursiveComparison().isEqualTo
like:
$ ./gradlew -PenableCrossCompilerPlugin=true :clouddriver-cloudfoundry:test --tests CloudFoundryLoadBalancerCachingAgentTest
> Task :clouddriver-cloudfoundry:test
CloudFoundryLoadBalancerCachingAgentTest > handleShouldReturnOnDemandResultsWithCacheTimeAndNoProcessedTime() FAILED
java.lang.AssertionError:
Expecting actual:
OnDemandAgent.OnDemandResult(sourceAgentType=account/CloudFoundryLoadBalancerCachingAgent-OnDemand, authoritativeTypes=[], cacheResult=com.netflix.spinnaker.cats.agent.DefaultCacheResult@8aeab9e, evictions={})
to be equal to:
OnDemandAgent.OnDemandResult(sourceAgentType=account/CloudFoundryLoadBalancerCachingAgent-OnDemand, authoritativeTypes=[], cacheResult=com.netflix.spinnaker.cats.agent.DefaultCacheResult@2a2dc0a, evictions={})
when recursively comparing field by field, but found the following difference:
field/property 'cacheResult.cacheResults.loadBalancers' differ:
- actual value : [com.netflix.spinnaker.clouddriver.cloudfoundry.cache.ResourceCacheData@bd31962c]
- expected value: [com.netflix.spinnaker.clouddriver.cloudfoundry.cache.ResourceCacheData@bd3195f1]
The following actual elements were not matched in the expected SingletonSet:
[com.netflix.spinnaker.clouddriver.cloudfoundry.cache.ResourceCacheData@bd31962c]
The recursive comparison was performed with this configuration:
- no overridden equals methods were used in the comparison (except for java types)
- these types were compared with the following comparators:
- java.lang.Double -> DoubleComparator[precision=1.0E-15]
- java.lang.Float -> FloatComparator[precision=1.0E-6]
- java.nio.file.Path -> lexicographic comparator (Path natural order)
- actual and expected objects and their fields were compared field by field recursively even if they were not of the same type, this allows for example to compare a Person to a PersonDto (call strictTypeChecking(true) to change that behavior).
at com.netflix.spinnaker.clouddriver.cloudfoundry.provider.agent.CloudFoundryLoadBalancerCachingAgentTest.handleShouldReturnOnDemandResultsWithCacheTimeAndNoProcessedTime(CloudFoundryLoadBalancerCachingAgentTest.java:191)
It's not clear why ignoring the order when comparing what looks like a singleton set is important, but I'd like to unblock the java 17 progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile to Java 11 bytecode using JDK 17.
Reference: spinnaker/igor#1198