-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): enable cross compilation plugin for Java 17 #6226
Merged
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3adcf87 - Browse repository at this point
Copy the full SHA 3adcf87View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e21375a - Browse repository at this point
Copy the full SHA e21375aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 857b46a - Browse repository at this point
Copy the full SHA 857b46aView commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 749b9a9 - Browse repository at this point
Copy the full SHA 749b9a9View commit details
Commits on Jun 23, 2024
-
chore(cloudfoundry): remove org.junit.platform.gradle.plugin
since it's deprecated (see junit-team/junit5#1317). Once it's gone, the regular gradle test task properly reports failures.
Configuration menu - View commit details
-
Copy full SHA for beb383c - Browse repository at this point
Copy the full SHA beb383cView commit details -
chore(cloudfoundry/test): replace deprecated isEqualToComparingFieldB…
…yFieldRecursively with usingRecursiveComparison().isEqualTo
Configuration menu - View commit details
-
Copy full SHA for 88ac6b9 - Browse repository at this point
Copy the full SHA 88ac6b9View commit details
Commits on Jun 24, 2024
-
fix(cloudfoundry/test): use ignoringCollectionOrder to fix test failures
like: $ ./gradlew -PenableCrossCompilerPlugin=true :clouddriver-cloudfoundry:test --tests CloudFoundryLoadBalancerCachingAgentTest > Task :clouddriver-cloudfoundry:test CloudFoundryLoadBalancerCachingAgentTest > handleShouldReturnOnDemandResultsWithCacheTimeAndNoProcessedTime() FAILED java.lang.AssertionError: Expecting actual: OnDemandAgent.OnDemandResult(sourceAgentType=account/CloudFoundryLoadBalancerCachingAgent-OnDemand, authoritativeTypes=[], cacheResult=com.netflix.spinnaker.cats.agent.DefaultCacheResult@8aeab9e, evictions={}) to be equal to: OnDemandAgent.OnDemandResult(sourceAgentType=account/CloudFoundryLoadBalancerCachingAgent-OnDemand, authoritativeTypes=[], cacheResult=com.netflix.spinnaker.cats.agent.DefaultCacheResult@2a2dc0a, evictions={}) when recursively comparing field by field, but found the following difference: field/property 'cacheResult.cacheResults.loadBalancers' differ: - actual value : [com.netflix.spinnaker.clouddriver.cloudfoundry.cache.ResourceCacheData@bd31962c] - expected value: [com.netflix.spinnaker.clouddriver.cloudfoundry.cache.ResourceCacheData@bd3195f1] The following actual elements were not matched in the expected SingletonSet: [com.netflix.spinnaker.clouddriver.cloudfoundry.cache.ResourceCacheData@bd31962c] The recursive comparison was performed with this configuration: - no overridden equals methods were used in the comparison (except for java types) - these types were compared with the following comparators: - java.lang.Double -> DoubleComparator[precision=1.0E-15] - java.lang.Float -> FloatComparator[precision=1.0E-6] - java.nio.file.Path -> lexicographic comparator (Path natural order) - actual and expected objects and their fields were compared field by field recursively even if they were not of the same type, this allows for example to compare a Person to a PersonDto (call strictTypeChecking(true) to change that behavior). at com.netflix.spinnaker.clouddriver.cloudfoundry.provider.agent.CloudFoundryLoadBalancerCachingAgentTest.handleShouldReturnOnDemandResultsWithCacheTimeAndNoProcessedTime(CloudFoundryLoadBalancerCachingAgentTest.java:191) It's not clear why ignoring the order when comparing what looks like a singleton set is important, but I'd like to unblock the java 17 progress.
Configuration menu - View commit details
-
Copy full SHA for 4dbcf8c - Browse repository at this point
Copy the full SHA 4dbcf8cView commit details
Commits on Jun 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 587ae8f - Browse repository at this point
Copy the full SHA 587ae8fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.