fix(core): conditionally hide expression evaluation warning messages #9771

mattgogerly · 2021-11-15T14:39:34Z

Filtering out expression evaluation failure messages if there are actual stage failure message(s) or if skipExpressionEvaluation is set to true in the context (since Orca still evaluates these, it just doesn't fail the stage).

christopherthielen · 2021-12-03T00:46:42Z

packages/core/src/pipeline/details/StageFailureMessage.tsx

+      if (isFailed || stage.context?.skipExpressionEvaluation) {
+        // filter out expression evaluation failure messages if:
+        // - there was an actual failure as these can get *really* long and hide the failure message
+        // - expression evaluation was explicitly disabled (as Orca still processes these and populates errors
+        //   even when disabled)
+        filteredMessages = stageMessages.filter((m) => !m.startsWith('Failed to evaluate'));
+      }


Can you explain this further? Why would we filter "failed to evaluate" messages when "isFailed" is true and "skipExpressionEvaluation" is false?

The failed to evaluate messages can get extremely long and are displayed even if expression evaluation is explicitly skipped in the stage config. In contrast the failure message is usually quite small. So if there's an actual failure message, OR if skipExpressionEvaluation is true, filtering them out removes noise and lets you see the actual error.

As far as I can tell expression evaluation failures are always warnings, but currently get lumped into the failure alert if there is a failure.

An example of this would be where an entire configmap is being printed because Orca failed to evaluate expressions in it, even though expression evaluation was explicitly disabled in the stage.

edit: updated to catch the case where the stage has been set to fail on failed expressions, in which case they should not be filtered

…filter-evaluation

mattgogerly · 2021-12-08T19:29:19Z

@Mergifyio update

mergify · 2021-12-08T19:29:23Z

update

✅ Branch has been successfully updated

link108 · 2022-01-11T01:30:47Z

@mattgogerly I'm seeing a warning with "No reason provided" in successful stages and I think this PR is what introduced the change, any chance you could take a look?

mattgogerly · 2022-01-11T14:00:15Z

@link108 any chance you could paste the execution?

martin-armory · 2022-01-11T16:44:55Z

@mattgogerly This can be reproduced on any pipeline, see screenshot for a simple 5-second Wait stage.

I'll point out the suspecting line shortly.

dogonthehorizon · 2022-01-12T04:07:34Z

I believe this should resolve the behavior we've been seeing:
#9794

…essages (#9771)" This reverts commit 7e3dd50.

…essages (#9771)" (#10021) This reverts commit 7e3dd50.

…essages (#9771)" (#10021) This reverts commit 7e3dd50. (cherry picked from commit 62033d0)

…essages (#9771)" (#10021) (#10022) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>

…essages (#9771)" (#10021) (#10023) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>

…essages (#9771)" (#10021) (#10025) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>

…essages (#9771)" (#10021) (#10024) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>

* fix: UI crashes when running pipeline(s) with many stages. (backport spinnaker#9960) (spinnaker#9974) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com> * Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10025) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com> * fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10035) * fix: Scaling bounds should parse float not int Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI * fix: Decimal support for upper/lower bound ASG tests (cherry picked from commit b763cae) Co-authored-by: Jason <jason.mcintosh@armory.io> * Fix CreateSecurityGroups ternary * Remove failing test for disabled action * Temporally adding GH workflows to build Docker from this branch * Temporally disabling other GHA workflows * Adding 'thd' prefix to IMAGE_NAME env var * Changing image name from 'deck' to 'thd-deck' * Apply master GHA changes --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com> Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com> Co-authored-by: Jason <jason.mcintosh@armory.io> Co-authored-by: Rodrigo Tovar <rodrigotovar398@gmail.com>

…essages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10023) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>

…essages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10022) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>

…essages (spinnaker#9771)" (spinnaker#10021) This reverts commit 7e3dd50.

* fix(core): Do not set static document base URL (spinnaker#9890) (spinnaker#9892) The previous change to enable optional path-based routing (spinnaker#9802) added a `<base>` tag, which regressed serving hash-based routing at non-root public paths. This change returns to AngularJS's default behavior when using hash-based routing. Note that path-based routing will continue to only function when served from a domain root. Resolves spinnaker/spinnaker#6723 (cherry picked from commit 5ac7516) Co-authored-by: jcavanagh <jcavanagh@users.noreply.github.com> * fix(aws): fix instance type selector by allowing instance types that can't be validated. (spinnaker#9893) (spinnaker#9895) * fix(aws): fix instance type selector by allowing instance types that can't be validated. spinnaker/spinnaker#6734 * fix(aws): adding test for instance type selector fix spinnaker/spinnaker#6734 (cherry picked from commit 563b6f6) Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> * fix(links): update link to spinnaker release changelog (spinnaker#9897) (spinnaker#9900) * fix(links): update link to spinnaker release changelog * prettier (cherry picked from commit 1591513) Co-authored-by: Jared Stehler <jared.stehler@gmail.com> * fix(aws): Fixing bugs related to clone CX when instance types are incompatible with image/region (spinnaker#9901) (spinnaker#9907) * fix(aws): Fixing bugs related to clone UX when instance types are incompatible with image/region Displaying warnings when incompatible instance types are removed spinnaker/spinnaker#6734 * fix(aws): PR feedback Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit d7290c4) Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> * chore(dependencies): Autobump spinnakerGradleVersion (spinnaker#9916) (spinnaker#9927) Co-authored-by: root <root@2dd4f76bffcc> (cherry picked from commit 64d03bc) Co-authored-by: spinnakerbot <spinbot@spinnaker.io> * feat(pipeline): added feature flag for pipeline when mj stage child (spinnaker#9914) (spinnaker#9921) * feat(pipeline): added feature flag for pipeline when mj stage child * fix(pipeline): added verification for sub pipe data * added guard verification for undefined data Co-authored-by: Fernando Freire <fernando.freire@armory.io> (cherry picked from commit 4b6fd53) Co-authored-by: Oscar Michel Herrera <oscarmichelh@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix(timeout): Added feature flag for rollback timeout ui input. (backport spinnaker#9937) (spinnaker#9941) * fix(timeout): Added feature flag for rollback timeout ui input. (spinnaker#9937) * fix(timeout): Added feature flag for rollback timeout ui input. * fix(timeout): Added feature flag for rollback timeout ui input. (cherry picked from commit e239be3) # Conflicts: # packages/amazon/src/pipeline/stages/rollbackCluster/rollbackClusterStage.html * fix(timeout): Added feature flag for rollback timeout ui input. (spinnaker#9944) --------- Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com> * [CN-1890] disable deploy options * fix(google): Resolved typo errors in GCE Autoscaler feature (spinnaker#9947) * Publish packages to NPM (spinnaker#9949) * chore(publish): publish packages (2250a47) - deck-app@2.4.3 - @spinnaker/google@0.2.4 * feat(peerdep-sync): Synchronize peerdependencies * chore(publish): publish peerdeps (2250a47) - @spinnaker/pluginsdk-peerdeps@0.9.0 --------- Co-authored-by: spinnakerbot <spinnakerbot@spinnaker.io> * [CN-1890] remove extra true * fix(6755): Resolved issue regarding warning reporting when cloning a server group in AWS (spinnaker#9948) * Revert "feat(Blue/Green): Add warning label and enhance disable/enable manifest stage with Deployment kind." (spinnaker#9951) * chore(dev): specifying React code for Deck PRs (spinnaker#9953) Co-authored-by: Cameron Motevasselani <cameron@armory.io> * feat(provider/cloudrun): Added cloudrun functionality to deck (spinnaker#9931) * feat(provider/cloudrun): Added cloudrun functionality to deck * feat(provider/cloudrun): Incorporated Suggested Changes * feat(provider/cloudRun): Fixed build issue --------- Co-authored-by: rsinghsidhu <rsinghsiddhu@salesforce.com> * chore(feature-flag): mj parent pipeline enabled by default (spinnaker#9954) Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com> * Publish packages to NPM (spinnaker#9955) * chore(publish): publish packages (e1b8d70) - deck-app@2.5.0 * feat(peerdep-sync): Synchronize peerdependencies * chore(publish): publish peerdeps (e1b8d70) - @spinnaker/pluginsdk-peerdeps@0.10.0 --------- Co-authored-by: spinnakerbot <spinnakerbot@spinnaker.io> * feat(deck): make StageFailureMessage component overridable (backport spinnaker#9994) (spinnaker#10007) * feat(deck): make StageFailureMessage component overridable (spinnaker#9994) (cherry picked from commit 39f70cc) # Conflicts: # version.json * chore(build): fix backport merge conflict --------- Co-authored-by: Matt <6519811+mattgogerly@users.noreply.github.com> * Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10024) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com> * fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10031) * fix: Scaling bounds should parse float not int Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI * fix: Decimal support for upper/lower bound ASG tests (cherry picked from commit b763cae) Co-authored-by: Jason <jason.mcintosh@armory.io> * feat(helm/bake): Add additional input fields where we can fill in details of the APIs versions (spinnaker#10036) (spinnaker#10046) - These input fields will not be pre-populated with versions of the target cluster available in the environment. - They will become part of the bake result. - Added API_VERSIONS_ENABLED env variable flag (cherry picked from commit d968183) Co-authored-by: Krystian <24556350+ciurescuraul@users.noreply.github.com> * fix: Updating Lambda functions available Runtimes (spinnaker#10055) (spinnaker#10056) (cherry picked from commit 669d1ed) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io> * Update 1.29.7 (#3) * fix: UI crashes when running pipeline(s) with many stages. (backport spinnaker#9960) (spinnaker#9974) Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com> * Revert "fix(core): conditionally hide expression evaluation warning messages (spinnaker#9771)" (spinnaker#10021) (spinnaker#10025) This reverts commit 7e3dd50. (cherry picked from commit 62033d0) Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com> * fix: Scaling bounds should parse float not int (spinnaker#10026) (spinnaker#10035) * fix: Scaling bounds should parse float not int Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI * fix: Decimal support for upper/lower bound ASG tests (cherry picked from commit b763cae) Co-authored-by: Jason <jason.mcintosh@armory.io> * Fix CreateSecurityGroups ternary * Remove failing test for disabled action * Temporally adding GH workflows to build Docker from this branch * Temporally disabling other GHA workflows * Adding 'thd' prefix to IMAGE_NAME env var * Changing image name from 'deck' to 'thd-deck' * Apply master GHA changes --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com> Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com> Co-authored-by: Jason <jason.mcintosh@armory.io> Co-authored-by: Rodrigo Tovar <rodrigotovar398@gmail.com> * Update GHA branch name * Disable cloudrun "Edit Load Balancer" --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: jcavanagh <jcavanagh@users.noreply.github.com> Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> Co-authored-by: Jared Stehler <jared.stehler@gmail.com> Co-authored-by: spinnakerbot <spinbot@spinnaker.io> Co-authored-by: Oscar Michel Herrera <oscarmichelh@gmail.com> Co-authored-by: DanielaS12 <111055962+DanielaS12@users.noreply.github.com> Co-authored-by: pjberry16 <pjberry16@gmail.com> Co-authored-by: SusmithaGundu <93190458+SusmithaGundu@users.noreply.github.com> Co-authored-by: Spinnaker Bot <87720302+spinnakerbot2@users.noreply.github.com> Co-authored-by: spinnakerbot <spinnakerbot@spinnaker.io> Co-authored-by: pjberry16 <76484282+pjberry16@users.noreply.github.com> Co-authored-by: Rajinderpal Singh Siddhu <61963157+siddhu-opsmx@users.noreply.github.com> Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com> Co-authored-by: Cameron Motevasselani <cameron@armory.io> Co-authored-by: rsinghsidhu <rsinghsiddhu@salesforce.com> Co-authored-by: Krzysztof Kotula <kkotula13@gmail.com> Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com> Co-authored-by: Matt <6519811+mattgogerly@users.noreply.github.com> Co-authored-by: Jason <jason.mcintosh@armory.io> Co-authored-by: Krystian <24556350+ciurescuraul@users.noreply.github.com> Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io> Co-authored-by: armory-abedonik <106548537+armory-abedonik@users.noreply.github.com> Co-authored-by: Rodrigo Tovar <rodrigotovar398@gmail.com>

fix(core): conditionally hide expression evaluation warning messages

ddef1cb

mattgogerly force-pushed the fix/filter-evaluation branch from c2e9e8e to ddef1cb Compare November 15, 2021 14:55

Merge branch 'master' into fix/filter-evaluation

23e096d

mattgogerly mentioned this pull request Nov 17, 2021

REQUEST: New Approver status for mattgogerly spinnaker/governance#277

Closed

6 tasks

mattgogerly added 2 commits November 30, 2021 20:17

Merge branch 'master' into fix/filter-evaluation

26f7842

Merge branch 'master' into fix/filter-evaluation

480ff0f

mattgogerly requested review from gal-yardeni and christopherthielen December 1, 2021 19:09

Merge branch 'master' into fix/filter-evaluation

9974472

christopherthielen reviewed Dec 3, 2021

View reviewed changes

mattgogerly added 3 commits December 3, 2021 14:02

chore(build): reorganise logic

c9de8a2

Merge remote-tracking branch 'origin/fix/filter-evaluation' into fix/…

21959ca

…filter-evaluation

chore(build): fix variable name

9413875

mattgogerly force-pushed the fix/filter-evaluation branch from 8b432f6 to 9413875 Compare December 3, 2021 14:13

mattgogerly added 2 commits December 3, 2021 21:10

Merge branch 'master' into fix/filter-evaluation

b89eb2c

Merge branch 'master' into fix/filter-evaluation

a6eca0c

christopherthielen approved these changes Dec 7, 2021

View reviewed changes

mattgogerly added the ready to merge Reviewed and ready for merge label Dec 8, 2021

Merge branch 'master' into fix/filter-evaluation

d032456

Merge branch 'master' into fix/filter-evaluation

040180e

mergify bot merged commit 7e3dd50 into spinnaker:master Dec 8, 2021

mattgogerly deleted the fix/filter-evaluation branch December 8, 2021 19:54

spinnakerbot added the target-release/1.28 label Dec 8, 2021

spinnakerbot2 mentioned this pull request Dec 8, 2021

Publish packages to NPM #9783

Merged

mattgogerly added a commit that referenced this pull request Aug 30, 2023

Revert "fix(core): conditionally hide expression evaluation warning m…

6c018b7

…essages (#9771)" This reverts commit 7e3dd50.

mattgogerly mentioned this pull request Aug 30, 2023

Revert "fix(core): conditionally hide expression evaluation warning messages (#9771)" #10021

Merged

mattgogerly added a commit that referenced this pull request Aug 30, 2023

Revert "fix(core): conditionally hide expression evaluation warning m…

62033d0

…essages (#9771)" (#10021) This reverts commit 7e3dd50.

mergify bot pushed a commit that referenced this pull request Aug 30, 2023

Revert "fix(core): conditionally hide expression evaluation warning m…

165172a

…essages (#9771)" (#10021) This reverts commit 7e3dd50. (cherry picked from commit 62033d0)

mergify bot pushed a commit that referenced this pull request Aug 30, 2023

Revert "fix(core): conditionally hide expression evaluation warning m…

9805372

…essages (#9771)" (#10021) This reverts commit 7e3dd50. (cherry picked from commit 62033d0)

mergify bot pushed a commit that referenced this pull request Aug 30, 2023

Revert "fix(core): conditionally hide expression evaluation warning m…

b65698a

…essages (#9771)" (#10021) This reverts commit 7e3dd50. (cherry picked from commit 62033d0)

mergify bot pushed a commit that referenced this pull request Aug 30, 2023

Revert "fix(core): conditionally hide expression evaluation warning m…

ecd1baa

…essages (#9771)" (#10021) This reverts commit 7e3dd50. (cherry picked from commit 62033d0)

spinnakerbot mentioned this pull request Dec 6, 2023

feat: Expose kayenta to plugin system #10070

Closed

sahititarigoppula pushed a commit to OpsMx/deck-oes that referenced this pull request Jun 5, 2024

Revert "fix(core): conditionally hide expression evaluation warning m…

0c00beb

…essages (spinnaker#9771)" (spinnaker#10021) This reverts commit 7e3dd50.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): conditionally hide expression evaluation warning messages #9771

fix(core): conditionally hide expression evaluation warning messages #9771

mattgogerly commented Nov 15, 2021

christopherthielen Dec 3, 2021

mattgogerly Dec 3, 2021 •

edited

Loading

mattgogerly commented Dec 8, 2021

mergify bot commented Dec 8, 2021

link108 commented Jan 11, 2022

mattgogerly commented Jan 11, 2022

martin-armory commented Jan 11, 2022

dogonthehorizon commented Jan 12, 2022

fix(core): conditionally hide expression evaluation warning messages #9771

fix(core): conditionally hide expression evaluation warning messages #9771

Conversation

mattgogerly commented Nov 15, 2021

christopherthielen Dec 3, 2021

Choose a reason for hiding this comment

mattgogerly Dec 3, 2021 • edited Loading

Choose a reason for hiding this comment

mattgogerly commented Dec 8, 2021

mergify bot commented Dec 8, 2021

✅ Branch has been successfully updated

link108 commented Jan 11, 2022

mattgogerly commented Jan 11, 2022

martin-armory commented Jan 11, 2022

dogonthehorizon commented Jan 12, 2022

mattgogerly Dec 3, 2021 •

edited

Loading