fix(core): ensure that users are not warned of their success #9794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ternary as written would allow a singleton list containing a single `null` to propagate throughout the render method of this warning message. This would result in a menacing "warning: no reason provided" message appearing on all stage executions. The assignment now states that a singleton list will only be provided iff `message` is non null and the `messages` array is empty.
link108
approved these changes
Jan 12, 2022
|
Thanks and sorry for not catching this case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ternary as written would allow a singleton list containing a single
nullto propagate throughout the render method of this warningmessage. This would result in a menacing "warning: no reason provided"
message appearing on all stage executions.
The assignment now states that a singleton list will only be provided
iff
messageis non null and themessagesarray is empty.