Skip to content

Commit

Permalink
fix(dependency): Issue with jackson-bom and kotlin-bom version confli…
Browse files Browse the repository at this point in the history
…ct resolution while upgrading the spring-boot 2.3.x (#1505)

* fix(dependency): Introducing spring dependency management gradle plugin

Spring boot has moved to gradle based dependency management from v2.3.x. This change has brought issue of conflict resolution failure of the Jackson-bom version and kotlin-bom version with gate service when it consumes the maven-bom generated by kork. The issue details are available in given link.
https://docs.google.com/document/d/1Ck4KeoB1ER0aQUTnf3e-x-M3i2Ur0It7YaaxEMiMXls/edit

To resolve this issue while upgrading gate service with spring v2.3.x, we must require the spring dependency management gradle plugin.

* Revert "fix(dependency): Introducing spring dependency management gradle plugin"

This reverts commit b3b2c9e.

* fix(dependency): Issue with jackson-bom and kotlin-bom version conflict resolution while upgrading the spring-boot 2.3.x.

The root cause of this issue is uncontrolled conflict resolution of jackson-bom and kotlin-bom dependency version imported from external maven BOM provided by kork-bom, as per the gradle documentation https://docs.gradle.org/6.9.1/userguide/platforms.html#sub:bom_import, we can use gradle enforcedPlatform closure as part of the implementation to strictly adhere the versions of direct and transitive dependencies imported BOM.

implementation(enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion"))
  • Loading branch information
j-sandy authored Feb 28, 2022
1 parent c9eb62c commit 7915082
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ allprojects {
}

dependencies {
implementation platform("io.spinnaker.kork:kork-bom:$korkVersion")
implementation enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion")
annotationProcessor platform("io.spinnaker.kork:kork-bom:$korkVersion")
annotationProcessor("org.springframework.boot:spring-boot-configuration-processor")
testAnnotationProcessor platform("io.spinnaker.kork:kork-bom:$korkVersion")
Expand Down

0 comments on commit 7915082

Please sign in to comment.