feat(travis): Always read properties from Travis stages #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jervi
added a commit
to jervi/echo
that referenced
this pull request
Mar 11, 2021
Travis doesn't need the value of the propertyFile field - it just needs it to be set to some value. Corresponds with spinnaker/orca#4089
jervi
added a commit
to jervi/deck
that referenced
this pull request
Mar 11, 2021
Travis doesn't need this field to fetch properties from builds. Depends on spinnaker/orca#4089 and spinnaker/echo#1090.
Travis doesn't need the propertyFile field - it just needs it to be set.
jervi
force-pushed
the
always_read_properties_from_travis
branch
from
171ce26 to
80a54de
Compare
dreynaud
approved these changes
Mar 23, 2021
# Conflicts: # orca-igor/src/main/java/com/netflix/spinnaker/orca/igor/pipeline/TravisStage.java
jervi
added a commit
to jervi/orca
that referenced
this pull request
Mar 23, 2021
Continuation of spinnaker#4089 - it should've been part of that PR really. Orca will now always check for properties from Travis, so it shouldn't fail if none are found.
mergify bot
pushed a commit
that referenced
this pull request
Mar 23, 2021
…ned (#4112) * fix(travis): Should not fail stage if Travis properties are not returned Continuation of #4089 - it should've been part of that PR really. Orca will now always check for properties from Travis, so it shouldn't fail if none are found. * Update orca-igor/src/main/java/com/netflix/spinnaker/orca/igor/tasks/GetBuildPropertiesTask.java Co-authored-by: Daniel Reynaud <dreynaud@netflix.com> * Fix stubbing * Turn the stub into a mock and add cardinality to make sure it is actually called Co-authored-by: Daniel Reynaud <dreynaud@netflix.com>
ajordens
pushed a commit
to spinnaker/echo
that referenced
this pull request
Apr 30, 2021
Travis doesn't need the value of the propertyFile field - it just needs it to be set to some value. Corresponds with spinnaker/orca#4089
jervi
added a commit
to jervi/deck
that referenced
this pull request
Aug 24, 2021
Travis doesn't need this field to fetch properties from builds. Depends on spinnaker/orca#4089 and spinnaker/echo#1090.
jervi
added a commit
to jervi/deck
that referenced
this pull request
Aug 25, 2021
Travis doesn't need this field to fetch properties from builds. Depends on spinnaker/orca#4089 and spinnaker/echo#1090.
mergify bot
added a commit
to spinnaker/deck
that referenced
this pull request
Sep 7, 2021
…ers (#8990) * feat(travis): Remove Property File field from Travis stages and triggers Travis doesn't need this field to fetch properties from builds. Depends on spinnaker/orca#4089 and spinnaker/echo#1090. * Use html enitities instead of curly braces to fix the build * Add echo command to help text * Add missing hash sign * Trigger new build Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis doesn't need the value of the propertyFile field - it just needs it to be set to some value.
Corresponds with spinnaker/echo#1090