fix(travis): Should not fail stage if Travis properties are not returned #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of spinnaker#4089 - it should've been part of that PR really. Orca will now always check for properties from Travis, so it shouldn't fail if none are found.
dreynaud
reviewed
Mar 23, 2021
| @@ -62,6 +62,9 @@ | |||
| stageDefinition.getMaster(), | |||
| stageDefinition.getJob()); | |||
| if (properties.size() == 0) { | |||
| if (stageDefinition.getMaster().startsWith("travis-")) { | |||
There was a problem hiding this comment.
any chance for stageDefinition.getMaster() to be null here?
There was a problem hiding this comment.
No, it is the name of the buildmaster. It needs to be defined and is fetched from igor.
There was a problem hiding this comment.
If it was null an exception would have been thrown a few lines up as well.
dreynaud
reviewed
Mar 23, 2021
orca-igor/src/main/java/com/netflix/spinnaker/orca/igor/tasks/GetBuildPropertiesTask.java
Outdated
Show resolved
Hide resolved
…GetBuildPropertiesTask.java Co-authored-by: Daniel Reynaud <dreynaud@netflix.com>
dreynaud
approved these changes
Mar 23, 2021
jervi
commented
Mar 23, 2021
...igor/src/test/groovy/com/netflix/spinnaker/orca/igor/tasks/GetBuildPropertiesTaskSpec.groovy
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4089 - it should've been part of that PR really.
Orca will now always check for properties from Travis, so it shouldn't fail if none are found.