Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve region detection logic on object store factory #741

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Improve region detection logic on object store factory #741

merged 1 commit into from
Nov 19, 2024

Conversation

lizardoluis
Copy link
Collaborator

@lizardoluis lizardoluis commented Nov 19, 2024 •
edited
Loading

  • Fix bug on region detection logic.

@lizardoluis lizardoluis self-assigned this Nov 19, 2024
@lizardoluis lizardoluis force-pushed the object_store_factory branch 2 times, most recently from 8f6b6c6 to 9d1f0a4 Compare November 19, 2024 11:03
timwaizenegger
timwaizenegger approved these changes Nov 19, 2024
View reviewed changes
Copy link

@timwaizenegger timwaizenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bucket is not relevant for the region detect decision. But the region is. If a region is configured, we should skip region detect.

@lizardoluis lizardoluis merged commit d24aecd into main Nov 19, 2024
2 checks passed
@lizardoluis lizardoluis deleted the object_store_factory branch November 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruuya gruuya gruuya approved these changes

@timwaizenegger timwaizenegger timwaizenegger approved these changes

Assignees

@lizardoluis lizardoluis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizardoluis @timwaizenegger @gruuya