Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve region detection logic on object store factory #741

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Improve region detection logic on object store factory #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion object_store_factory/src/aws.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ pub async fn add_amazon_s3_specific_options(
url: &Url,
options: &mut HashMap<AmazonS3ConfigKey, String>,
) {
if !options.contains_key(&AmazonS3ConfigKey::Bucket)
if !options.contains_key(&AmazonS3ConfigKey::Region)
&& !options.contains_key(&AmazonS3ConfigKey::Endpoint)
{
let region = detect_region(url).await.unwrap();
Expand Down