Skip to content

Commit

Permalink
Merge pull request #256 from splitio/rum-agent-integration/suite
Browse files Browse the repository at this point in the history
Update to support Split Suite (RUM Agent integration)
  • Loading branch information
EmilianoSanchez authored Oct 10, 2023
2 parents aef1561 + 8e55350 commit 124b59c
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@splitsoftware/splitio-commons",
"version": "1.9.1",
"version": "1.9.2-rc.2",
"description": "Split Javascript SDK common components",
"main": "cjs/index.js",
"module": "esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion src/logger/messages/info.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as c from '../constants';
import { codesWarn } from './warn';

const READY_MSG = 'Split SDK is ready';
const READY_MSG = 'Split SDK client is ready';

export const codesInfo: [number, string][] = codesWarn.concat([
// client status
Expand Down
5 changes: 4 additions & 1 deletion src/sdkClient/clientCS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export function clientCSDecorator(log: ILogger, client: SplitIO.IClient, key: Sp
// Key is bound to the `track` method. Same thing happens with trafficType but only if provided
track: trafficType ? clientCS.track.bind(clientCS, key, trafficType) : clientCS.track.bind(clientCS, key),

isClientSide: true
// Not part of the public API. These properties are used to support other modules (e.g., Split Suite)
isClientSide: true,
key,
trafficType
}) as SplitIO.ICsClient;
}
1 change: 1 addition & 0 deletions src/storages/AbstractSegmentsCacheSync.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export abstract class AbstractSegmentsCacheSync implements ISegmentsCacheSync {

/**
* Only used for the `skC`(segment keys count) telemetry stat: 1 for client-side, and total count of keys in server-side.
* @TODO for client-side it should be the number of clients, but it requires a refactor of MySegments caches to simplify the code.
*/
abstract getKeysCount(): number

Expand Down

0 comments on commit 124b59c

Please sign in to comment.