fix #165: validate when plugin is configured

current way create tesk instances even though it is not necessary.
this change applies the same way with the official CodeNarc plugin
validating configuration in setter method:
https://github.com/gradle/gradle/blob/df7ac484a2facbb4503ba911666367de22b1d16a/subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CodeNarcExtension.java

CHANGELOG.md

@@ -1,3 +1,4 @@
+
 # Changelog
 
 This is the changelog for SpotBugs Gradle Plugin. This follows [Keep a Changelog v1.0.0](http://keepachangelog.com/en/1.0.0/).
@@ -6,6 +7,10 @@ Currently the versioning policy of this project follows [Semantic Versioning](ht
 
 ## Unreleased - 2019-??-??
 
+### Fixed
+
+* Avoid needless task creation (#165)
+
 ## 2.0.0 - 2019-05-13
 
 ### Removed

src/main/java/com/github/spotbugs/SpotBugsPlugin.java

@@ -10,7 +10,6 @@
 import java.util.Properties;
 import java.util.concurrent.Callable;
 
-import org.gradle.api.Project;
 import org.gradle.api.artifacts.Configuration;
 import org.gradle.api.artifacts.DependencySet;
 import org.gradle.api.file.FileCollection;
@@ -61,37 +60,6 @@ protected Class<SpotBugsTask> getTaskType() {
  protected void beforeApply() {
  verifyGradleVersion(GradleVersion.current());
  configureSpotBugsConfigurations();
- project.afterEvaluate(this::verify);
- }
-
- private void verify(Project p) {
- p.getTasks().withType(SpotBugsTask.class).forEach(task -> {
- SpotBugsReports reports = task.getReports();
- if (reports.getText() != null && reports.getText().getDestination() == null) {
- String message = String.format(
- "Task '%s' has no destination for TEXT report. Set reports.text.destination to this task.",
- task.getName());
- throw new IllegalStateException(message);
- }
- if (reports.getXml() != null && reports.getXml().getDestination() == null) {
- String message = String.format(
- "Task '%s' has no destination for XML report. Set reports.xml.destination to this task.",
- task.getName());
- throw new IllegalStateException(message);
- }
- if (reports.getHtml() != null && reports.getHtml().getDestination() == null) {
- String message = String.format(
- "Task '%s' has no destination for HTML report. Set reports.html.destination. to this task",
- task.getName());
- throw new IllegalStateException(message);
- }
- if (reports.getEmacs() != null && reports.getEmacs().getDestination() == null) {
- String message = String.format(
- "Task '%s' has no destination for EMACS report. Set reports.emacs.destination. to this task",
- task.getName());
- throw new IllegalStateException(message);
- }
- });
  }
 
  /**

src/main/java/com/github/spotbugs/SpotBugsTask.java

@@ -10,10 +10,7 @@
 
 import javax.inject.Inject;
 
-import org.gradle.api.Action;
-import org.gradle.api.GradleException;
-import org.gradle.api.Incubating;
-import org.gradle.api.JavaVersion;
+import org.gradle.api.*;
 import org.gradle.api.file.FileCollection;
 import org.gradle.api.file.FileTree;
 import org.gradle.api.logging.LogLevel;
@@ -186,9 +183,25 @@ public SpotBugsReports reports(Closure closure) {
  @Override
  public SpotBugsReports reports(Action<? super SpotBugsReports> configureAction) {
  configureAction.execute(reports);
+ verify(reports);
  return reports;
  }
 
+ private void verify(SpotBugsReportsInternal reports) {
+ if (reports.getText() != null && reports.getText().getDestination() == null) {
+ throw new InvalidUserDataException("No destination for TEXT report. Set reports.text.destination to this task.");
+ }
+ if (reports.getXml() != null && reports.getXml().getDestination() == null) {
+ throw new InvalidUserDataException("No destination for XML report. Set reports.xml.destination to this task.");
+ }
+ if (reports.getHtml() != null && reports.getHtml().getDestination() == null) {
+ throw new InvalidUserDataException("No destination for HTML report. Set reports.html.destination to this task.");
+ }
+ if (reports.getEmacs() != null && reports.getEmacs().getDestination() == null) {
+ throw new InvalidUserDataException("No destination for EMACS report. Set reports.emacs.destination to this task.");
+ }
+ }
+
  /**
  * The filename of a filter specifying which bugs are reported.
  *