Task creation avoidance

[daanschipper]

For every sourceSet, spotbugs-gradle-plugin creates a spotbugsSourceSetName task which is created during configuration. This hurts performance for larger projects with multiple source sets, as 1000+ tasks are created.

I've pinpointed the task creation to the method com.github.spotbugs.SpotBugsPlugin.verify(), where the task objects are instantiated with p.getTasks().withType(SpotBugsTask.class).forEach(task ->.

[KengoTODA]

This is the behaviour comes from Gradle official code quality plugin mechanism, such as https://github.com/gradle/gradle/blob/master/subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/internal/AbstractCodeQualityPlugin.java

Then you have two options:

1. Ask Gradle itself to improve performance in your case, or
2. Contribute to bring Breaking change required: reduce dependency on Gradle internal API #104 into reality.

[daanschipper]

No, that is not true. I've commented out project.afterEvaluate(this::verify); and recompiled, after that the tasks are not created.

To add, other tasks extending the AbstractCodeQualityPlugin do also not create tasks, eg Checkstyle

[KengoTODA]

Right, the change 578b7a1 is introduced only to SpotBugs plugin, and it seems that other code quality plugin no longer extends beforeApply().

[KengoTODA]

BTW which tasks do you mean? In my understanding CheckStylePlugin still creates tasks for each source set.

[daanschipper]

This is regarding creation the actual Task object, which you want to avoid during configuration time. With project.register, from the link you provided, you only create a TaskProvider object.

You can check this yourself by running ./gradlew help --scan, under 'Performance' -> 'Configuration' you can see how many tasks are created during configuration. For example, see this build scan.