Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.0.0 #174

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Release 5.0.0 #174

merged 11 commits into from
Oct 16, 2024

Conversation

tjofas
Copy link
Collaborator

@tjofas tjofas commented Oct 16, 2024

What this PR does / why we need it:
Time for a new release as we are dropping support for Python 3.8 and adding support for 3.11
Changes include:

  • Drop support for Python 3.8
  • Add support for Python 3.11
  • Fixes bad cropping in png introduced by changes to chrome webdriver
  • Add support and recommendation to use make black for code formatting

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

5.0.0 (2024-10-16)

* Drop support for Python 3.8
* Add support for Python 3.11
* Fixes bad cropping in png introduced by changes to chrome webdriver
* Add support and recommendation to use make black for code formatting

jhyching and others added 11 commits October 2, 2024 14:00
@jhyching
use the bokeh get_screenshot_as_png instead and add option functionality
272b917 
Changes in either Selenium or the ChromeDriver causes the lower parts of charts to be cropped in the png output. The Bokeh `get_screenshot_as_png` has some smarter calculations to overcome this. Plus it also allows a scale factor to improve output resolution.
@jhyching
run notebook to ensure output are the same
0780e5c
@jhyching
remove unused dependency
0ea2b7f
@jhyching
bump bokeh min. version to support scale_factor
96c9689
@jhyching
drop support for py38
93d36ee
@jhyching
fix error in examples
e562e59
@jhyching
update coverage
d6e9e59
@tjofas
drop support for python3.8, add support for 3.11 and prep for new rel…
1664e66 
…ease
@tjofas
update build to python3.9
a027bac
@tjofas
fix formatting using make black
305984e
@tjofas
Merge pull request #172 from jhyching/fix_png_sizing
4fcf369 
Fix png sizing
@jhyching jhyching self-requested a review October 16, 2024 09:06
jhyching
jhyching approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@jhyching jhyching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@jhyching jhyching merged commit 488415f into master Oct 16, 2024
6 checks passed
@tjofas tjofas deleted the Release-5.0.0 branch October 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhyching jhyching jhyching approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjofas @jhyching