Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

#308 Extend repository validation by allowing port number. #309

Merged
merged 4 commits into from
Oct 15, 2019

Conversation

mmaeller
Copy link

Adjusted regex validation to allow port number.

@mmaeller
Copy link
Author

mmaeller commented Aug 1, 2019

You're right, I changed it accordingly.

@stephanedaviet
Copy link

You got a problem of automatic formatting on the file TestRepoNameValidation at lines 10 and 12: the end of line spaces have been stripped. Thus the header license check test in Travis fails. You should fix it so that the PR became mergeable.

Note, I comment because we are also interested in this fix ;-).

@mmaeller
Copy link
Author

Thx @stephanedaviet , fixed 👍

@rbdiang
Copy link

rbdiang commented Aug 29, 2019

The port validation rule is also tripping us up. We push to a private docker registry listening on a different port. When will this fix be merged and available in maven central?

@wendro
Copy link

wendro commented Sep 9, 2019

Can it land in snapshots - soon?

@cvgaviao
Copy link

Hey, could some maintainer to merge this fix, please ?

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mattnworb
Copy link
Member

I've released v1.4.13 with this change, I'll update the changelog shortly. Thanks again for the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants