Clarify file permission error message #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @ajornetic3, @freider and @bmaggard to be potential reviewers |
|
I like it, but while making the change, why not also them consistent? I like the one I switched to back on PR #1456 (b/c: "(got: %s)"), but that can be reverted if others don't:
|
Make it clear that permission should either be 'r' or 'w'.
|
@bmaggard updated pull request to make them consistent. |
Current coverage is 76.10%@@ master #1692 diff @@
==========================================
Files 94 94
Lines 10285 10285
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8106 7827 -279
- Misses 2179 2458 +279
Partials 0 0
|
|
This is good-to-go as far as I'm concerned. |
|
No real critiques here. Improved error reporting 👍 |
|
This looks very good, thanks! One thing we should fix is that it shouldn't be such a general exception as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that permission should either be 'r' or 'w'.
The original "r/w" suggestion was not clear to me, was passing 'w+' originally, then interpreted the error as a request to use 'rw' until i looked at the actual source code :)