Remove the confusing "dummy_test_module" directory #1756
Conversation
|
@Tarrasch, thanks for your PR! By analyzing the annotation information on this pull request, we identified @daveFNbuck, @erikbern and @themalkolm to be potential reviewers |
Tarrasch
force-pushed
the
remove-not-imported-file
branch
from
7f3d02a
to
4a32a04
Compare
The purpose is simply to remove a confusing module from the luigi root directory. It was only used from tests but it couldn't be put in the test module for whatever technical reasons.
Tarrasch
force-pushed
the
remove-not-imported-file
branch
from
4a32a04
to
e1baf1c
Compare
Current coverage is 76.15%@@ master #1756 diff @@
==========================================
Files 95 95
Lines 10350 10350
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8157 7882 -275
- Misses 2193 2468 +275
Partials 0 0
|
|
@daveFNbuck, does this look sane to you? |
|
I'm not sure it makes sense to import the unloaded module for the dynamic On Wed, Jul 13, 2016 at 9:43 PM, Arash Rouhani notifications@github.com
|
Not sure we're on the same page. The helper creates a module (a file within our PYTHONPATH) without loading it. Later, we run |
|
Sounds good. |
* spotify/master: (24 commits) Add DateSecondParameter to parameter.py (spotify#1779) tox: Specify sphinx dependency better flake8: Unbreak travis build Excludes .tox from flake8 to prevent checking third-party libraries (spotify#1785) README: Remove monthly downloads badge Rename CentralPlannerScheduler to Scheduler (spotify#1781) Remove abstract Scheduler class (spotify#1778) Assistants: Don't affect longevity of tasks (spotify#1772) tests: Skip a inttermittently failing s3 test (spotify#1777) Update retcodes to handle new cases (spotify#1771) tests: Fix warning in remote_scheduler_test.py (spotify#1774) Remove sitecustomize file (spotify#1755) Fix exist method for ftp server Update copy() to return number and size of files copied Remove the confusing "dummy_test_module" directory (spotify#1756) Disable codecov comments on GitHub PRs (spotify#1754) Fix "owner_email" log message. (spotify#1762) docs: Install sphinx 1.4.4 in setup.py (spotify#1761) docs: Set minimum versions for sphinx (spotify#1760) Normalize ListParameter to be Immutable (spotify#1759) ...
This was just forgotten to be included in #1756
This was just forgotten to be included in #1756
Description
Remove the confusing "dummy_test_module" directory
Motivation and Context
The purpose is simply to remove a confusing module from the luigi root
directory. It was only used from tests but it couldn't be put in the
test module for whatever technical reasons.
Have you tested this? If so, how?
This is only affecting tests. If tests pass it should be OK.