Added --dont-remove-tmp-dir parameter to SGEJobTask. #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brcopeland, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jfeala to be a potential reviewer |
|
will merge if you rebase :) |
brcopeland
force-pushed
the
retain_tmp_dir
branch
from
0476f55
to
ab61e29
Compare
brcopeland
force-pushed
the
retain_tmp_dir
branch
from
78874ae
to
44dcd29
Compare
|
Rebase done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added parameter to retain the temporary directory created to run the Task on the cluster.
Motivation and Context
This change is helpful for debugging. Without the change, the temporary directory is always removed, even when, say, it fails it can be helpful to examine the directory to see what was copied, the log files, etc.
Have you tested this? If so, how?
I've been using this change without issue for several months.