Don't kill the worker when it cannot connect to smtp server #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@interskh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jackdwyer, @palicand and @dlstadther to be potential reviewers |
|
Nice catch! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch socket.error exception when trying to connect smtp server in error email notification.
Motivation and Context
Worker dies when it tries to send out error email but cannot connect to smtp server. This is rather unfortunate in production environment. This PR is intended to fix it.
Have you tested this? If so, how?
I have included unit test.