Make temporary_path() decorator create directories #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that my program crashed in the cases where I didn't manually create the directories. And in all cases so far I've needed for the directories to be created. Will I definetly think this feature should be possible to turn off, I think it's best to have as "on by default". But I left it out for anyone making a patch in the future.
|
@Tarrasch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jcrobak, @steenzout and @gpoulin to be potential reviewers. |
dlstadther
approved these changes
Nov 16, 2016
Tarrasch
commented
Nov 17, 2016
| *Note*: This method is optional, not all FileSystem subclasses implements it. | ||
|
|
||
| *Note*: parents and raise_if_exists were added in August 2014. Some | ||
| implementations might not support these flags yet. |
There was a problem hiding this comment.
A note for however is curious.
I think these two notes add negative value only. In general we want people to implement this method (in particular after this patch). If we leave these old (and currently mis-rendered) notes, file system implementors might not implement this method referring to this.
|
If nobody else complains I'll merge this tomorrow. :) (I've verified that the Travis Issue is not this patch's fault) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that my program crashed in the cases where I didn't manually
create the directories. And in all cases so far I've needed for the
directories to be created.
Will I definitely think this feature should be possible to turn off, I
think it's best to have as "on by default". But I left it out for anyone
making a patch in the future.
Have you tested this? If so, how?
I've added test cases and tested it very lightly in production.