emails: Increase logging if email is misconfigured #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tarrasch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @interskh, @daveFNbuck and @neilisaac to be potential reviewers. |
dlstadther
approved these changes
Dec 13, 2016
|
I think I added the same patch locally while debugging a few times. Thanks for making it a PR! |
daveFNbuck
approved these changes
Dec 13, 2016
Tarrasch
added a commit
to Tarrasch/luigi
that referenced
this pull request
Dec 21, 2016
kreczko
pushed a commit
to kreczko/luigi
that referenced
this pull request
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you tested this? If so, how?
Yes. I got more verbose output when testing with
luigi TestNotificationsTask --local-scheduler --email-force-sendI got something like this:
Instead of a mere
ERROR: Not able to connect to smtp server.