Add redshift copy support for role-based credential string #1962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redshift copy supports key-based (with optional session token) or role-based credentials. This PR adds support for role-based credentials, making them the default choice if both role- and key-based are provided (since they are more restrictive and thus secure), and refactors implementation of optional session token for the key-based credential string.
Description
aws_account_id
andaws_arn_role_name
aws_access_key_id
andaws_secret_access_key
from@abc.abstractproperty
to@property
NotImplementedError
when no pair of credentials are provided to account for the lack of@abc.abstractproperty
pair of credentialsNotImplementedError
raises if no pair of creds are provided.Motivation and Context
Transitioning to the use of role-based cred string for redshift copy. Maintain key-based creds. Refactor key-based session token.
Have you tested this? If so, how?
Single unit test for ensuring exception is raised if no pair of creds are provided.
Actual success of use has been verified for the 4 (most likely) cases: