add TaskStatusReporter class to fix Windows pickle issue #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows uses a different method when forking, which causes issues with the task status updating functions that are passed to TaskProcess (they need to be pickle-able). This introduces a new class to encapsulate task status updating that is also pickle-able.
Tarrasch
approved these changes
Jan 19, 2017
|
Unless anybody objects or have other review-points. I'll merge this in soon. |
kreczko
pushed a commit
to kreczko/luigi
that referenced
this pull request
Mar 28, 2017
Windows uses a different method when forking, which causes issues with the task status updating functions that are passed to TaskProcess (they need to be pickle-able). This introduces a new class to encapsulate task status updating that is also pickle-able.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows uses a different method when forking, which caused issues with
the task status updating functions that are passed to TaskProcess
(they need to be pickle-able). Basically running with >1 worker was broken
on Windows. See #1423
This fixes the problem by introducing a new pickle-able class to encapsulate task status
update methods.
Have you tested this? If so, how?
test/task_status_message_test.py)--workers 10before the change to reproduce the issue (got pickle error), then after and the test succeeded -- tested with py2.7