Fixed problem that the retry policy per task does not work. #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtoriumi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @daveFNbuck, @erikbern and @Tarrasch to be potential reviewers. |
|
I was wondering why my retry policy per task doesn't work and hasn't got a chance to fix it. Thank you very much for the fix! |
|
This looks correct. But this requires test cases before it can be merged. Also I would like to know for which code paths it does work, and which new code paths this patch solves. |
interskh
pushed a commit
to Houzz/luigi
that referenced
this pull request
Feb 22, 2017
|
Previously, it worked normally if the task failed twice, and it failed normally when it failed three times. Therefore, it was fixed as a test case when the task failed three times. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where "retry policy per task" is not given as a parameter of add_task in _handle_next_task.