Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Weebly to list of Luigi users #2056

Merged
merged 1 commit into from
May 1, 2017

Conversation

jasonmay
Copy link
Contributor

@jasonmay jasonmay commented Mar 7, 2017

Description

Addition to documentation

Motivation and Context

This solves the issue that Weebly is a cool company but people don't know they use Luigi.

Have you tested this? If so, how?

I clicked 'Preview' and it looked fine.

@mention-bot
Copy link

@jasonmay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @erikbern, @jcrobak and @Tarrasch to be potential reviewers.

@dlstadther
Copy link
Collaborator

Do you have any blog or PR post about Weebly's use of Luigi? I believe the preference is to link to useful applications of Luigi, more so than company homepages.

@jasonmay
Copy link
Contributor Author

jasonmay commented Mar 7, 2017

We don't have any posts at the moment, if that's a requirement, I'd be happy to discuss with my team about publishing something.

@dlstadther
Copy link
Collaborator

I'm not sure it's a requirement, but it's preferred. In general, it would be awesome to see more luigi blog posts out there though!

@erikbern
Copy link
Contributor

erikbern commented Mar 8, 2017

yes would prefer to link to something!

@erikbern
Copy link
Contributor

wonder if we should drop the requirement a bit and link to anyone that uses luigi, presentation or not.

@Tarrasch
Copy link
Contributor

Not sure. Airflow have that kind of list, it's surely a lot bigger, but I'm not sure if it's providing value. I maybe prefer Luigi's list, as sometimes linked presentations are useful, but sometimes it's just links to websites or other repositories, so the quality and consistency is a bit low right now...

@dlstadther
Copy link
Collaborator

@Tarrasch & @erikbern ,

I think this depends on the image we're trying to convey here. If we just want to show that a lot of companies are/have using/used Luigi, then we go the Airflow route and accept links to homepages. However, if the goal is to provide interesting use cases/implementations of luigi then we go the latter.

As @Tarrasch noted, we currently have some of both. So perhaps we split the middle and accept links to homepages, but add references to blogs after the company name. Something like the following:

Spotify (presentation)
Schibsted
Example Company (presentation) (blog)

If we agree on this, i'm happy to submit the PR to modify the current README for this change.

@erikbern
Copy link
Contributor

yeah i like @dlstadther's idea. i was thinking along the same lines. i would also put all companies with presentations or blog posts above the companies without

@erikbern
Copy link
Contributor

can you rebase on latest changes now? thanks!

@dlstadther
Copy link
Collaborator

@jasonmay Please rebase on the latest changes. We'd be happy to merge your company into our list! Thanks!

@jasonmay
Copy link
Contributor Author

jasonmay commented May 1, 2017

It's rebased now; thanks for reviewing!

@dlstadther dlstadther merged commit dd41a18 into spotify:master May 1, 2017
@dlstadther
Copy link
Collaborator

Thanks @jasonmay !

This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants