Fix worker tool box in visualizer #2063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The worker toolbox in the visualizer shows some buggy information in the phase between adding a worker to the scheduler and actual task processing (so while the dependency tree is built). This looks like:
The reason is that
workers
is both used for the list of worker objects in the visualizer for rendering and the number of worker processes of a worker. See here (first and last line in the marked area). Initially, there's no 'worker' field in the worker object so Mustache falls back to the list of workers which renders to the example above.Motivation and Context
A simple renaming of the variable that holds the list of worker objects for rendering fixes the bug (2nd commit). In addition, the worker toolbox is removed now entirely when a worker is disabled (1st commit). Previously, the "disable" button was removed while the "add workers" menu was still visible.