Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Newsela to list of companies using Luigi #2065

Merged
merged 5 commits into from
Apr 5, 2017

Conversation

rayrrr
Copy link
Contributor

@rayrrr rayrrr commented Mar 15, 2017

We use Luigi at Newsela for ETL stuff, and we like it!

@mention-bot
Copy link

@rayrrr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @erikbern, @jcrobak and @Tarrasch to be potential reviewers.

@Tarrasch
Copy link
Contributor

We usually prefer links to slidedecks, presentations or blogposts. Do you have anything like that to link to instead of just to your website?

@rayrrr
Copy link
Contributor Author

rayrrr commented Mar 23, 2017

@Tarrasch not right now. We'd still like to be included on the list though, but it's up to you.

@dlstadther
Copy link
Collaborator

Hey @rayrrr, we've revamped how we record companies which use Luigi. We can accept your company into the list. Just resolve the conflict here and add your company to the list without extra luigi-related media. Thanks!

@dlstadther
Copy link
Collaborator

I'm not sure why this commit shows +6 instead of +1. But whatever. I'll merge after build turns green. Thanks

Got a bit mixed up fixing merge conflicts in the GitHub UI. This should make the build pass.
@rayrrr
Copy link
Contributor Author

rayrrr commented Apr 5, 2017

My mistake while resolving merge conflicts. It's +1 now. Build should pass 🤞 thanks!

@rayrrr
Copy link
Contributor Author

rayrrr commented Apr 5, 2017

At this point the build failure appears to be systemic:

Warning, treated as error:
README.rst:117: WARNING: Duplicate explicit target name: "spotify".
ERROR: InvocationError: '/home/travis/build/spotify/luigi/.tox/docs/bin/sphinx-build -W -b html -d /home/travis/build/spotify/luigi/.tox/docs/tmp/doctrees doc doc/_build/html'
___________________________________ summary ____________________________________
ERROR:   docs: commands failed
The command "./scripts/ci/conditional_tox.sh" exited with 1.

@dlstadther
Copy link
Collaborator

dlstadther commented Apr 5, 2017

@rayrrr I keep seeing that error on multiple builds. Nothing you did.

I'm going to merge anyway as error is unrelated. Thanks for submitting!

@dlstadther dlstadther merged commit ce47e03 into spotify:master Apr 5, 2017
@dlstadther
Copy link
Collaborator

@Tarrasch something needs to be done about this build error. Also, the purpose of having these tests run is that they should be fast. However, the two -cdh builds alone take well over 30 minutes each to complete. What do they even test?

This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants