luigi.worker.Worker(retry_external_tasks=True) has no effect #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kalvdans, thanks for your PR! By analyzing the history of the files in this pull request, we identified @daveFNbuck, @erikbern and @Tarrasch to be potential reviewers. |
Tarrasch
approved these changes
Apr 5, 2017
| """ | ||
| Test ExternalTask without altering global settings. | ||
| """ | ||
| assert luigi.worker.worker().retry_external_tasks is False |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the retry_external_tasks parameter local to the worker instead of the global settings.
Motivation and Context
The change is required when starting a worker from Python. It is not needed when starting a worker using the luigi binary.
Have you tested this? If so, how?
I have included unit tests. The test don't run to completion without the change to the code.