Set hideDone on in graph links #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have hideDone set by default, as this default can prevent large graphs from freezing the visualiser. This went away when we moved to storing the checkbox state in the URL bar, but we have an easy fix by adding it to the link.
|
@daveFNbuck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nmb10, @riga and @Tarrasch to be potential reviewers. |
|
Sounds reasonable to me! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to have hideDone set by default, as this default can prevent large graphs from freezing the visualiser. This went away when we moved to storing the checkbox state in the URL bar, but we have an easy fix by adding it to the link.
Motivation and Context
I tend to have large graphs where most items are done, so this feature is the difference between a near-immediate response and a delay of tens of seconds or minutes. We used to have this feature, it seems to have been an accidental removal.
Have you tested this? If so, how?
I used this locally and in production and it works.