hivevar option in hive query task #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stroykova, thanks for your PR! By analyzing the history of the files in this pull request, we identified @erikbern, @steenzout and @themalkolm to be potential reviewers. |
dlstadther
approved these changes
Jul 17, 2017
|
@JoeEnnever Hello! Seems like you developed the hive support for luigi. Could you please review these changes? |
rizzatti
approved these changes
Sep 12, 2017
|
👍 seems good to me |
|
Thanks for your contribution @stroykova ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hivevarsmethod was added. Dictionary items fromhivevarsare included to argument list as --hivevar options. It is needed for separate variables namespace.Motivation and Context
The hiveconf namespace and --hiveconf should be used to set Hive configuration values.
The hivevar namespace and --hivevar should be used to define user variables.
Setting user variables under the hiveconf namespace probably won't break anything, but isn't recommended.
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+VariableSubstitution
Have you tested this? If so, how?
I have included unit tests.