accept kwargs for mysql connection #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dstandish, thanks for your PR! By analyzing the history of the files in this pull request, we identified @steenzout, @rantav and @themalkolm to be potential reviewers. |
dlstadther
approved these changes
Sep 2, 2017
|
@dlstadther ok docstring has been amended. |
dlstadther
approved these changes
Sep 5, 2017
|
@dstandish Sorry for the delay in merging! Thanks for your first Luigi contribution! |
|
No worries. First anything contribution ha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Allows you to supply additional connection params to mysql connector. E.g. if you need to supply an SSL cert.
Have you tested this? If so, how?
I observed that it allowed me to connect and use the target.