Fix "IF NOT EXISTS" Postgres 8 incompatibility #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the closest postgres for redshift is postgres 8. this means that companies still use postgres 8 to mock a local redshift on their dev environment.
|
@angelinemm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tarrasch, @ant1j and @smehan to be potential reviewers. |
dlstadther
approved these changes
Sep 8, 2017
There was a problem hiding this comment.
Firstly, thanks for submitting your first PR! Welcome!
Secondly, given your use case for Postgres 8 this revert makes sense. While I prefer the cleanliness of if not exists, the use of this older version of postgres is valid (although I'm not sure you'd run into problems running most Redshift SQL in a Postgres 9.x environment).
|
If it helps compatibility, no problem. |
|
Thanks @angelinemm for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Postgres 8 incompatibility
Description
Commit a41e4c4 introduced a postgres 8 incompatibility by using IF NOT EXISTS in the sql query that creates the marker table. It was done to simplify code and getting rid of exception handling.
IF NOT EXISTS is supported only since postgres 9.1
Motivation and Context
Postgres 8 is arguably quite an old version but it's the version that amazon's redshift is based on.
It makes sense for companies that use redshift in production to use postgres 8 in development environment.
Have you tested this? If so, how?
I ran the tests suggested here: https://github.com/spotify/luigi/blob/master/CONTRIBUTING.rst
Also this commits is a revert, so it reintroduces code that was already used before.