Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intent refactor #2255

Merged
merged 1 commit into from Nov 17, 2017
Merged

Intent refactor #2255

merged 1 commit into from Nov 17, 2017

Conversation

TMaYaD
Copy link
Contributor

@TMaYaD TMaYaD commented Oct 14, 2017

minor refactoring to make some of the intent clearer.

dlstadther
dlstadther approved these changes Oct 14, 2017
View reviewed changes
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would feel better if Travis build would run to confirm all green

@TMaYaD
Copy link
Contributor Author

TMaYaD commented Nov 10, 2017

@dlstadther PTAL now that the Travis builds have been fixed.

@dlstadther
Copy link
Collaborator

@Tarrasch Mind double checking me on this. It LGTM though.

@Tarrasch Tarrasch merged commit 8ae5b65 into spotify:master Nov 17, 2017
@Tarrasch
Copy link
Contributor

LGTM. Thanks @TMaYaD!

@TMaYaD TMaYaD deleted the intent-refactor branch November 20, 2017 05:57
This was referenced Jun 29, 2022
Closed
Closed
@mdragilev mdragilev mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TMaYaD @dlstadther @Tarrasch