Removed message 'No Instance(s) Available.' in Windows when starting … #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, happened to miss that os was already imported. Is this ok or should I make a totally new branch and create a new request? |
|
I am a bit lost of why my pull-request would fail the |
Tarrasch
approved these changes
Dec 9, 2017
|
So, what is needed to get this one merged? |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Window when starting luigi the message
No Instance(s) Available.is shown in the terminal. This is due to the fact that commandwmicthrows this error if no process with the given pid is found. We really do not care about this error, so this change redirects the error message tonulThe method of redirecting standard error was found here:
https://stackoverflow.com/questions/4507312/how-to-redirect-stderr-to-null-in-cmd-exe
Motivation and Context
The message was confusing to new users and gave no important information.
See for example here: https://stackoverflow.com/questions/40593709/luigi-no-instances-available
Have you tested this? If so, how?
Updated the unit tests to work with Windows, and have run my pipeline without problems.