Add Python 3.7 compatibility #2466
Conversation
|
If successful, will need to update README |
|
At least one error is caused by: getmoto/moto#1706 |
|
With regard to the moto error, we'll need to update our moto version with the Python 3.7 compatible version. We're currently testing against So an additional PR may need to be submitted to update our moto test dependency. I'll submit a naive WIP one to see how badly things break. |
* upstream-master: Remove long-deprecated scheduler config variable alternatives (spotify#2491) Bump tornado milestone version (spotify#2490) Update moto to 1.x milestone version (spotify#2471) Use passed password when create a redis connection (spotify#2489) S3 client refactor (spotify#2482) Rename to rpc_log_retries, and make it apply to all the logging involved Factor log_exceptions into a configuration parameter Fix attribute forwarding for tasks with dynamic dependencies (spotify#2478) Add a visiblity level for luigi.Parameters (spotify#2278) Add support for multiple requires and inherits arguments (spotify#2475) Add metadata columns to the RDBMS contrib (spotify#2440) Fix race condition in luigi.lock.acquire_for (spotify#2357) (spotify#2477) tests: Use RunOnceTask where possible (spotify#2476) Optional TOML configs support (spotify#2457) Added default port behaviour for Redshift (spotify#2474) Add codeowners file with default and specific example (spotify#2465) Add Data Revenue to the `blogged` list (spotify#2472) Fix Scheduler.add_task to overwrite accepts_messages attribute. (spotify#2469) Use task_id comparison in Task.__eq__. (spotify#2462)
|
The dist/sudo flags need to set within the matrix so they don't break other python builds. Also, I guess the previous trusty image had postgres installed/running without specification. but it looks like postgres needs to be added into services for the xenial dist. dalejung#1 is green on Travis. Lemme know if you want me to open a new PR or just grab the changes from there. |
|
Thanks so much @dalejung ! I hadn't found the time to resolve the postgres issue. I've copied your build changes here. |
|
👍 Had to wrangle with travis updating some personal libs. Happy the info was useful elsewhere. |
* upstream-master: Fix S3Client.copy return value consistency (spotify#2488) s3client check for deprecated host keyword and raise error with the details (spotify#2493) Fix exception when toml lib is not installed (spotify#2506) Add Okko to companies that use luigi (spotify#2512) Added optional choice for hdfs clients (spotify#2487) Version 2.7.8 revert tornado upgrade Version 2.7.7 added a new event 'progress' (spotify#2498) Add Uppsala University / pharmb.io as user (spotify#2496)
|
GREEN BUILD! Houston, we have Python 3.7 compatibility! |
|
@ulzha / @honnix How's this look to you? At some point, we should probably do something about our test speed. We're now exceeding 30m to find out if everything passes. What are your (and @Tarrasch 's) thoughts on cutting down to Py2.7, 3.7 explicit support? I understand many people may be using 34/35/36, but testing |
|
Hard decision, but 30m is way too much. I wish I could find some stats of which Python versions are more popular than the other. :/ |
|
I guess my above answer is not helping at all. :D How about we drop 34/35 first? Give 36 one more year? |
|
I'd support dropping tests for 34/35. If we go that route, i'd suggest updating our README to denote previous support for those versions, but that they are no longer included in the the automated test suite. |
|
Sound like a plan. Let's go for it. BTW, in readme we say 3.3 still, lol. |
|
Cool. I push those changes here shortly. Then this will be good to merge. Thanks @honnix ! |
|
26 min build. But a step in the right direction |
|
👍 |
|
Is this worth a minor version bump? I'm drafting and releasing |
|
If we're dropping explicit (tested) support for Python versions, i'd say this deserves Thanks for taking care of |
|
|
* upstream-master: Add Python 3.7 compatibility (spotify#2466) Refactor s3 copy into sub-methods (spotify#2508) Remove s3 bucket validation prior to file upload (spotify#2528) Version 2.7.9 set upper bound of python-daemon Update MockTarget mode to accept r* or w* (spotify#2519)
Description
Python 3.7.0 has been released. Time to check for Luigi compatibility.
Motivation and Context
Let's try to keep up with most recent Python versions!
Have you tested this? If so, how?
Letting Travis do this :)