Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[broken] Fix params hashing #2539

Closed
wants to merge 57 commits into from
Closed

[broken] Fix params hashing #2539

wants to merge 57 commits into from

Conversation

orsinium
Copy link
Contributor

Description

Fixed hashing when dict passed as parameter for task via TOML config.

Motivation and Context

Fix #2538

Have you tested this? If so, how?

  1. I ran test cases from Luigi task does not accept dict defined in TOML Config file. #2538
  2. I've included dict parameter into config example which loads in tests.

orsinium added 30 commits July 13, 2018 13:45
@orsinium
mv cfg parser
d00f793
@orsinium
split cfg parser and config getter
783ddeb
@orsinium
+TOML config parser
fd4e30f
@orsinium
improve config getter
d712827
@orsinium
+Apache License in new files
bcb59e0
@orsinium
TOML config parser tests
0242248
@orsinium
override configs by keys
debea65
@orsinium
Documentation for TOML config parser
ddfb5be
@orsinium
Merge branch 'config'
d0caa72
@orsinium
FIX lexer error
3261393 
Pygments doesn't supports TOML by default

https://gitlab.com/gitlab-org/gitlab-pygments-rb/commit/d460ba68716937e59498f95fd34709d98990dea3
@orsinium
FIX lexer error
edf41c8 
Pygments doesn't supports TOML by default

https://gitlab.com/gitlab-org/gitlab-pygments-rb/commit/d460ba68716937e59498f95fd34709d98990dea3
@orsinium
FIX: no shared instance between different config parsers
1d0d110
@orsinium
rm unused os import
6142834
@orsinium
Merge remote-tracking branch 'origin/config'
d86414a
@orsinium
+getitem for config
b88376a
@orsinium
improve config paths
f4c128a
@orsinium
add config function
ba20f7b
@orsinium
sort imports
22b7368
@orsinium
make additional parsers optional
95fa46b
@orsinium
Merge branch 'improve-config'
beeb92f
@orsinium
improve add_config_path for default parser
913fe19
@orsinium
Merge branch 'improve-config'
03fb9ba
@orsinium
FIX package installation
ae050b0
@orsinium
Merge branch 'improve-config'
a5c85f9
@orsinium
FIX TOML parser raises KeyError, not NoSectionError
284cc26
@orsinium
Merge branch 'improve-config'
4b43134
@orsinium
Merge branch 'improve-config' into config
0d6943a
@orsinium
some improvements after review.
a7047fa
@orsinium
Merge branch 'config'
135d7d1
@orsinium
Merge remote-tracking branch 'spotify/master' into config
1c9129b
orsinium added 21 commits August 2, 2018 19:30
@orsinium orsinium mentioned this pull request Sep 28, 2018
Closed
@orsinium
Copy link
Contributor Author

Wow, so many commits O.o

@orsinium orsinium changed the title Fix params hashing [closed] Fix params hashing Sep 28, 2018
@orsinium orsinium closed this Sep 28, 2018
@orsinium
Copy link
Contributor Author

orsinium commented Sep 28, 2018 •
edited
Loading

I've cherry-picked all commits into #2540. Use it instead of this PR.

@orsinium orsinium changed the title [closed] Fix params hashing [broken] Fix params hashing Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther Awaiting requested review from dlstadther dlstadther is a code owner

@Tarrasch Tarrasch Awaiting requested review from Tarrasch

@ulzha ulzha Awaiting requested review from ulzha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orsinium