Fix params hashing #2540
Merged
Fix params hashing #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orsinium
requested review from
dlstadther,
Tarrasch and
ulzha
as code owners
This was referenced Sep 28, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions. |
|
Would this PR be merged...? |
|
PR has approvement of @Tarrasch. So, it's just waiting for merging, I guess >.< |
|
This is close to a year old now I see. Can you rebase? Maybe ask somone else to review it in addition to me? |
|
Nobody wants to review it. We are lonely and abandoned in this world 😩 |
|
Hi @orsinium , I found that the execution summary of Case 1 in issue #2538 would depend on the length of the task name and the number of variables. A Shorter task name with a small number of variables led to failure. |
|
@fullflu, sounds too magic. Please, make an issue with steps to reproduce. It'll help a lot. |
|
@dlstadther, could you review this PR, please? |
dlstadther
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Looks like most of these changes where moving the location of FrozenOrderedDict (and its slight rename).
So the real changes here are:
- recursively freezing TOML dicts in
read() - ignore string types from being loaded from FrozenOrderedDict in
parse()
Assuming i've caught the changes, i'm good here.
| @@ -22,6 +22,7 @@ | |||
| toml = False | |||
|
|
|||
| from .base_parser import BaseParser | |||
| from ..freezing import recursively_freeze | |||
There was a problem hiding this comment.
why are we referencing relative paths? can we not from luigi.configuration.freezing import recursively_freeze?
|
@dlstadther Could you please merge it because I'm out of the context here? Thanks. |
drowoseque
pushed a commit
to drowoseque/luigi
that referenced
this pull request
Nov 28, 2019
* move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring
honnix
pushed a commit
that referenced
this pull request
Dec 2, 2019
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Dec 3, 2019
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Dec 3, 2019
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
drowoseque
pushed a commit
to drowoseque/luigi
that referenced
this pull request
Dec 6, 2019
This reverts commit 2f41f26.
honnix
pushed a commit
that referenced
this pull request
Dec 16, 2019
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Dec 16, 2019
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
honnix
pushed a commit
that referenced
this pull request
Jan 2, 2020
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Jan 2, 2020
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
honnix
pushed a commit
that referenced
this pull request
Jan 20, 2020
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Jan 20, 2020
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
drowoseque
pushed a commit
to drowoseque/luigi
that referenced
this pull request
Jan 23, 2020
This reverts commit 2f41f26.
honnix
pushed a commit
that referenced
this pull request
Jan 28, 2020
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Jan 28, 2020
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
honnix
pushed a commit
that referenced
this pull request
Jan 28, 2020
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Jan 28, 2020
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
honnix
pushed a commit
that referenced
this pull request
Jan 28, 2020
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Jan 28, 2020
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
honnix
pushed a commit
that referenced
this pull request
Feb 13, 2020
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
honnix
pushed a commit
that referenced
this pull request
Jun 1, 2020
* no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import
honnix
pushed a commit
that referenced
this pull request
Jun 1, 2020
* Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.{u,b} * joined * Update .travis.yml * "except ImportError" removed (#2845) * py2/py3 import error eliminated * E402 module level import not at top of file * E303 too many blank lines (3) * snakebite removed (#2833) * snamebite removed * no minicluster * no minicluster * flake8 * branches - master * no snakebite in tox.ini * [luigi.six.itervalues] usage removed (#2835) * no itervalues * no exception * [luigi.six.assertCountEqual] removed (#2841) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.assertCountEqual -> self.assertCountEqual * no ununsed import * E128 continuation line under-indented for visual indent * [luigi.six.next] removed (#2842) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no six.next * yield from instead of loop * too-many-blank-lines * `luigi.six.add_metaclass` removed (#2843) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * six.add_metaclass -> metaclass= * six.add_metaclass -> metaclass= * no `from __future__ import ...` (#2846) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no from __future__ import * [luigi.six.string_types] and [luigi.six.binary_type] removed (#2838) * no string_types * no-binary_type * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * original * no ununsed import * Update .travis.yml * Fix params hashing (#2540) * move params freezing to separated module * freeze dict for toml parser * FIX FrozenOrderedDict name * Freeze only params of config, not all config * +docstring * [luigi.mock.MockFile] removed (#2839) * no-mock-file * MockFile removed * unused import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * no string_types * no-binary_type * original * no ununsed import * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * new string_types * snakebite * no-unused-import * utf-8 in auth * no unused imports * py27 -> py37 in CONTRIBUTING.rst * E231 missing whitespace after ',' * [luigi.six.moves] removed (#2844) * Update .travis.yml * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * no-six-moves * del attr removed * del attr removed * exec_ removed * py 2.7 mentions removed from README and setup.py (#2852) * 2.7 mentions removed from README and setup.py * py27 -> py37 in CONTRIBUTING.rst * abstractproperty -> property + abstractmethod (#2847) * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * abstractproperty -> property + abstractmethod * Update beam_dataflow.py * Update beam_dataflow.py * no-if-six.py* (#2840) * no-if-six.py* * no unused imports * Update .travis.yml * no py27 in travis (#2836) * no py27 in travis * py37 * flake8 and docs back * py36 py37 postgres * py36-apache * MixedUnicodeBytes removed * unused imports removed * no-if-py3 * space * space * MixedUnicodeBytesFormat returned * postgres toxenv for py3 * postgres toxenv for py3 * postgres toxenv for py3 * \n * no-unused-import * test_multiple_workers back * F401 'luigi.six' imported but unused * test_url_without_basic_auth fix * [luigi.six.iteritems] usage removed (#2834) * iteritems usage removed * no unused imports * bmo * bmo * iteritems removed * no doc for iteritems * most_common from collections.Counter * returning tuple * postgres toxenv for py3 * original * no-unused-import * F401 'luigi.six' imported but unused * blank line * F401 'luigi.six' imported but unused * six.b('...') -> b'...' * blank line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed hashing when dict passed as parameter for task via TOML config.
Motivation and Context
Fix #2538
Have you tested this? If so, how?