Add scope to routes, to unify url with frontend #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/routes.rb
Outdated
| resource :account, controller: :account, only: %i[show create update] | ||
| resources :account_confirmations, only: %i[show] | ||
| resources :passwords, controller: :passwords, only: %i[create update] | ||
| namespace :api, defaults: { format: 'json' } do |
There was a problem hiding this comment.
The API in Spree is not locale-scoped, so these routes should go outside of the scope :locale thing
There was a problem hiding this comment.
For them, locale is always passed as a query param
There was a problem hiding this comment.
Oh, that makes sense. I've fixed it.
|
@wjwitek , I think I found a place where the locale is still not persisting, can you check it out? Steps:
Hopefully I've correctly replicated your setup :P |
nciemniak
suggested changes
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
nciemniak
reviewed
Dec 5, 2022
|
Great so far on covering the various test cases, this'll really help us make sure we're not breaking locale in the future. I feel like this'll be good to go once the tests are ironed out 💪 |
Co-authored-by: nciemniak <nciemniak@gmail.com>
Co-authored-by: nciemniak <nciemniak@gmail.com>
Co-authored-by: nciemniak <nciemniak@gmail.com>
Co-authored-by: nciemniak <nciemniak@gmail.com>
Co-authored-by: nciemniak <nciemniak@gmail.com>
nciemniak
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change locale from being in url as param, to being part of url, using scope in routes.
It will break locale for legacy_frontend however (they'll be lost while clicking log out etc.), without this fix spree/spree_rails_frontend#31.