Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add url types connected to spree_auth_devise #39

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

wjwitek
Copy link
Contributor

@wjwitek wjwitek commented Nov 30, 2022

@nciemniak
Copy link
Contributor

@wjwitek it would be good to have some tests on the frontend that confirm that locale is being persisted - Capybara is used for integration testing in the legacy frontend repo, can you look into setting up a couple tests to confirm that when user navigates from one page to another, that the locale is included in the url? (especially in the cases where we found it was not working if certain params were not set)

I believe there is a test file already created for testing locale related behavior.

This might help:
https://stackoverflow.com/questions/11224290/test-redirection-with-rspec-and-capybara-rails

@nciemniak
Copy link
Contributor

Looks great 😎 👍

@nciemniak nciemniak merged commit 682ad4a into spree:main Dec 6, 2022
@wjwitek wjwitek deleted the fx_for_spree_auth_devise branch December 6, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants