Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change com.github.tomakehurst:wiremock-jre8-standalone coordinates to allow migration to version 3.0.0+ #1933

Open
helpermethod opened this issue Sep 1, 2023 · 10 comments

Comments

@helpermethod
Copy link

With Wiremock 3.0.0, groupId and artifactId have changed from

com.github.tomakehurst:wiremock-jre8-standalone

to

org.wiremock:wiremock-standalone

By adapting the coordinates, you should still get automated dependency updates.

I can provide a PR if applicable.

@marcingrzejszczak
Copy link
Contributor

Hey, have the packages changed too? Cause if they did that's a breaking change.

@helpermethod
Copy link
Author

At least not yet, though some APIs have been deprecated

https://github.com/wiremock/wiremock/tree/master/src/main/java/com/github/tomakehurst/wiremock

@marcingrzejszczak
Copy link
Contributor

I see. I'll have to think about it but actually we could theoretically support both versions. These are 2 separate jars, we can have 2 different conditionals on classes etc. Do we know if the stub JSON produced by WireMock 3 is compatible with WireMock 2 ?

@helpermethod
Copy link
Author

According to the docs the JSON output/API should be the same.

@helpermethod
Copy link
Author

Doesn't spring-cloud-contract package Wiremock? So upgrading to the lastest version should be transparent to the user, right?

@marcingrzejszczak
Copy link
Contributor

We're in touch with @oleg-nenashev to add support for WireMock 3. We'll keep everyone posted in this issue

@oleg-nenashev
Copy link

The upgrade is expected to be mostly transparent, but we need to do some integration testing. The update is unlikely to be just a dependency groupId and artifactId change, we have quite a lot of API changes

@yeikel
Copy link

yeikel commented Nov 20, 2023

I just want to pass by to mention that CVE-2023-44487 is currently impacting the 2.x version (even if it is not exploitable given that this is a test dependency) .

See https://blog.cloudflare.com/technical-breakdown-http2-rapid-reset-ddos-attack/

@nhomble
Copy link

nhomble commented Jul 23, 2024

The upgrade is expected to be mostly transparent, but we need to do some integration testing. The update is unlikely to be just a dependency groupId and artifactId change, we have quite a lot of API changes

Just wondering, is the way forward still dependent on some new integration tests on the wiremock side? I'm also happy to contribute to get this moving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants