Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1933 - Upgrading Wiremock to 3.3.0 #2092

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cameleeck
Copy link
Contributor

Attempt to upgrade Wiremock to version 3.X.X.

There are some tradeoff's to make it happen:

  • There is no implementation of FormParameters/ServeEventListeners| as i wanted to keep change small
  • Added Jakarta Annotation api as Spring 6 is based on Jakarta EE 9+

@tomasbjerre
Copy link

Relates to #1933 #1942 #2031 #2104.

WireMock 3.0.0 was released on 2023-08-30. I think it is important to get this job done ASAP.

Any specific issue we are waiting for here? Perhaps me, or someone else, can help.

@spencergibb
Copy link
Member

We typically don't update dependencies to a new major version until spring cloud has a major release as well

@raynigon
Copy link

@spencergibb What is the current release plan for 2024.0.X?
Will this only be released for Spring Boot 3.3, or will there be a 2023.1.X compatible with Spring Boot 3.2 ?

@spencergibb
Copy link
Member

spencergibb commented May 22, 2024

2024.0 is scheduled to be compatible with boot 3.4.x at the end of November or beginning of December. 2023.0.x will be compatible with both boot 3.2.x and 3.3.x with a release later this month

@salbracco24
Copy link

salbracco24 commented Aug 28, 2024

Hi, @spencergibb I'm a bit unclear. So I see the latest stable release of Spring Cloud Contract is 4.1.4. Do you know which version will support WireMock 3.3.1? And is the release still targeted for December 2024?

Also, we're now at WireMock 3.9.1. It would be nice if it could even support that.

Thanks!

@andeb
Copy link

andeb commented Sep 24, 2024

Hello @spencergibb @marcingrzejszczak, apologies for bumping this thread. Is there any plan to upgrade wiremock to 3.x stream? I can also help to contribute to the changes but wondering if there's any plan from Spring team to merge it in the near future.

Btw, thanks for this project, it's very helpful and neat.

@marcingrzejszczak
Copy link
Contributor

Thank you! We are having discussions about this. We will get back to you once we have a solution. We do remember about this topic :)

@dogruis
Copy link

dogruis commented Oct 3, 2024

This is a real bottleneck. The mr is almost a year old and it's still a draft.

@tomasbjerre
Copy link

tomasbjerre commented Oct 9, 2024

We released 3.0.0 of WireMock Spring Boot:
https://github.com/wiremock/wiremock-spring-boot

It changes some things that will hopefully make the transition to that very easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants