Skip to content

loader: archive main class should fall back to Main-Class attribute if the Start-Class attribute is unavailable #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
patrikbeno opened this issue Mar 18, 2015 · 4 comments
Closed

loader: archive main class should fall back to Main-Class attribute if the Start-Class attribute is unavailable #2684

patrikbeno opened this issue Mar 18, 2015 · 4 comments
Labels
status: duplicate A duplicate of another issue status: superseded An issue that has been superseded by another

Comments

@patrikbeno
Copy link

see

spring-boot/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/archive/Archive.java

Line 50 in cb067ee

public String getMainClass() throws Exception {

@patrikbeno
Copy link
Author

#2685

@wilkinsona
Copy link
Member

What's your use case for falling back to Main-Class?

@patrikbeno
Copy link
Author

Null layout, or pluggable layouts in general, as introduced in #2629.

You may have a layout that does not inject loader and/or does not override archive entry point (Main-Class).
In such case, expected behavior is to leave Main-Class as is.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2015
@wilkinsona wilkinsona removed the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2015
@snicoll
Copy link
Member

snicoll commented Jan 8, 2017

Closing in favour of pr #2685

@snicoll snicoll closed this as completed Jan 8, 2017
@snicoll snicoll added the status: duplicate A duplicate of another issue label Jan 8, 2017
@philwebb philwebb added the status: superseded An issue that has been superseded by another label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@snicoll @philwebb @wilkinsona @patrikbeno @spring-projects-issues