spring-boot-2684 loader: archive main class should fall back to Main-Class attribute if the Start-Class attribute is unavailable #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrikbeno
force-pushed
the
spring-boot-2684-archive-main-class
branch
2 times, most recently
from
79573bd to
c3b3243
Compare
patrikbeno
force-pushed
the
spring-boot-2684-archive-main-class
branch
3 times, most recently
from
4340c41 to
08eb571
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
@patrikbeno Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@patrikbeno Thank you for signing the Contributor License Agreement! |
…Class attribute if the Start-Class attribute is unavailable
patrikbeno
force-pushed
the
spring-boot-2684-archive-main-class
branch
from
08eb571 to
183a206
Compare
|
We don't think falling back to the main-class is a good idea. #7263 should now give much more flexibility with custom layouts. |
philwebb
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.