Skip to content

Repackager: pluggable layouts #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

patrikbeno
Copy link

Repackager: layouts refactoring. Layouts are now pluggable: specify fully qualified name of the class implementing the Layout interface, or use known legacy aliases (JAR, ZIP, DIR, ...)

This effectivelly obsoletes #2619 and #2620.

Thanks @philwebb for idea.

This is initial draft. Submitting early because of those obsoleted requests that are being reviewed.

@@ -0,0 +1,29 @@
package org.springframework.boot.loader.tools.layout;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dedicating new package for layouts because referencing nested classes in Gradle is tricky (you need to use dollar which must be escaped in Gradle, and also, this is difference between Maven and Gradle, hence confusing...)

@philwebb philwebb added this to the 1.3.0 milestone Mar 10, 2015
@patrikbeno
Copy link
Author

ok, so now this actually obsoletes #2620 (see daa966c)

@pivotal-issuemaster
Copy link

@patrikbeno Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@patrikbeno Thank you for signing the Contributor License Agreement!

@wilkinsona
Copy link
Member

Thanks for the PR and sorry for the huge delay. As with #7263, we're not keen on the layouts no longer being strongly typed. Using a String means that people will lose auto-completion in their IDE and we want to avoid that. Our current preference is to keep our existing layout support as-is, but to allow a whole new layout "engine" to be plugged in. We will, by convention, pass some configuration into the engine, allowing more control over its behaviour.

@wilkinsona wilkinsona closed this Nov 6, 2016
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants