-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Repackager: pluggable layouts #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c2ffda2
to
7ec646d
Compare
@@ -0,0 +1,29 @@ | |||
package org.springframework.boot.loader.tools.layout; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dedicating new package for layouts because referencing nested classes in Gradle is tricky (you need to use dollar which must be escaped in Gradle, and also, this is difference between Maven and Gradle, hence confusing...)
2b9080d
to
87d00d0
Compare
4ac8138
to
cf401c1
Compare
…ully qualified name of the class implementing the Layout interface, or use known legacy aliases (JAR, ZIP, DIR, ...)
…. Improved error reporting.
cf401c1
to
49af74e
Compare
@patrikbeno Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@patrikbeno Thank you for signing the Contributor License Agreement! |
Thanks for the PR and sorry for the huge delay. As with #7263, we're not keen on the layouts no longer being strongly typed. Using a |
Repackager: layouts refactoring. Layouts are now pluggable: specify fully qualified name of the class implementing the Layout interface, or use known legacy aliases (JAR, ZIP, DIR, ...)
This effectivelly obsoletes #2619 and #2620.
Thanks @philwebb for idea.
This is initial draft. Submitting early because of those obsoleted requests that are being reviewed.